-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest MapLibre Style Spec #2756
Conversation
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2756-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2756-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2756-compared-to-main.txt |
...android/MapLibreAndroid/src/main/java/org/maplibre/android/style/layers/PropertyFactory.java
Show resolved
Hide resolved
...android/MapLibreAndroid/src/main/java/org/maplibre/android/style/layers/PropertyFactory.java
Show resolved
Hide resolved
Not sure what I'm reading, so my review is limited... |
@HarelM Just wanted to give a heads up that we are going to be depending on the style spec again. :) When there are MapLibre GL JS specific descriptions it should indicate so. |
@HarelM It was not my intention to request a review. But I'll address your other comments! |
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2756-compared-to-main.txt |
v8.json
) to latest version.platform/android/scripts/generate-style-code.mjs
which was removed in Use ESM in Node.js code generation scripts #2739. We should run this on CI (created an issue Run Android code generation on CI #2755).platform/android
.package.json
inplatform/android
@HarelM FYI