Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest MapLibre Style Spec #2756

Merged
merged 15 commits into from
Aug 26, 2024
Merged

Use latest MapLibre Style Spec #2756

merged 15 commits into from
Aug 26, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Aug 23, 2024

@HarelM FYI

@louwers louwers self-assigned this Aug 23, 2024
Copy link

github-actions bot commented Aug 23, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2756-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.0Mi  +420% +25.1Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2756-compared-to-legacy.txt

Copy link

github-actions bot commented Aug 23, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0031         +0.0031             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2756-compared-to-main.txt

@HarelM
Copy link
Collaborator

HarelM commented Aug 23, 2024

Not sure what I'm reading, so my review is limited...

@louwers
Copy link
Collaborator Author

louwers commented Aug 23, 2024

@HarelM Just wanted to give a heads up that we are going to be depending on the style spec again. :) When there are MapLibre GL JS specific descriptions it should indicate so.

@louwers
Copy link
Collaborator Author

louwers commented Aug 23, 2024

@HarelM It was not my intention to request a review. platform/android/scripts/generate-style-code.js This file got moved, it is not a new script.

https://github.com/maplibre/maplibre-native/pull/2739/files#diff-ef5dacef315a975fb3c4947d6afb00e0b2168959b4de7f40ab485c7abe429d03

But I'll address your other comments!

Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2756-compared-to-main.txt

@louwers louwers enabled auto-merge (squash) August 26, 2024 20:45
@louwers louwers merged commit db95ba1 into maplibre:main Aug 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants