Update Android Dependencies, use maplibre-gestures-android #2714

louwers · 2024-08-12T12:45:40Z

Update dependencies.
Add dependency on kotlinx-coroutines-core which was missing (test app).
Add dependency on kotlinx-coroutines-android which was missing (test app).
Use maplibre-gestures-android to replace mapbox-gestures-android.
Update NDK render test app.
Use JVM Toolchain. https://blog.jetbrains.com/kotlin/2021/11/gradle-jvm-toolchain-support-in-the-kotlin-plugin/

Bumps the dependencies group with 10 updates in the /platform/android directory: | Package | From | To | | --- | --- | --- | | [org.jetbrains.kotlinx:kotlinx-coroutines-test](https://github.com/Kotlin/kotlinx.coroutines) | `1.6.4` | `1.8.1` | | androidx.annotation:annotation | `1.8.1` | `1.8.2` | | [org.jetbrains.kotlin:kotlin-gradle-plugin](https://github.com/JetBrains/kotlin) | `2.0.0` | `2.0.10` | | com.android.tools.lint:lint | `31.5.1` | `31.5.2` | | com.android.tools.lint:lint-api | `31.5.1` | `31.5.2` | | com.android.tools.lint:lint-checks | `31.5.1` | `31.5.2` | | com.android.tools.lint:lint-tests | `31.5.1` | `31.5.2` | | com.android.tools.build:gradle | `8.5.1` | `8.5.2` | | org.jetbrains.kotlin.android | `2.0.0` | `2.0.10` | | org.jetbrains.kotlin.plugin.serialization | `2.0.0` | `2.0.10` | Bumps the dependencies group with 5 updates in the /render-test/android directory: | Package | From | To | | --- | --- | --- | | androidx.test.ext:junit | `1.1.4` | `1.2.1` | | androidx.test:rules | `1.5.0` | `1.6.1` | | androidx.test.espresso:espresso-core | `3.5.0` | `3.6.1` | | androidx.appcompat:appcompat | `1.5.1` | `1.7.0` | | com.android.tools.build:gradle | `8.5.1` | `8.5.2` | Bumps the dependencies group with 6 updates in the /test/android directory: | Package | From | To | | --- | --- | --- | | androidx.test.ext:junit | `1.1.4` | `1.2.1` | | androidx.test:rules | `1.5.0` | `1.6.1` | | androidx.test.espresso:espresso-core | `3.5.0` | `3.6.1` | | androidx.appcompat:appcompat | `1.5.1` | `1.7.0` | | com.android.tools.build:gradle | `8.5.1` | `8.5.2` | | [io.github.vvb2060.ndk:curl](https://github.com/vvb2060/curl-android) | `8.8.0` | `8.9.1-lto-ndk27` | Updates `org.jetbrains.kotlinx:kotlinx-coroutines-test` from 1.6.4 to 1.8.1 - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.6.4...1.8.1) Updates `androidx.annotation:annotation` from 1.8.1 to 1.8.2 Updates `org.jetbrains.kotlin:kotlin-gradle-plugin` from 2.0.0 to 2.0.10 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.0.0...v2.0.10) Updates `com.android.tools.lint:lint` from 31.5.1 to 31.5.2 Updates `com.android.tools.lint:lint-api` from 31.5.1 to 31.5.2 Updates `com.android.tools.lint:lint-checks` from 31.5.1 to 31.5.2 Updates `com.android.tools.lint:lint-tests` from 31.5.1 to 31.5.2 Updates `com.android.tools.lint:lint-api` from 31.5.1 to 31.5.2 Updates `com.android.tools.lint:lint-checks` from 31.5.1 to 31.5.2 Updates `com.android.tools.lint:lint-tests` from 31.5.1 to 31.5.2 Updates `com.android.tools.build:gradle` from 8.5.1 to 8.5.2 Updates `org.jetbrains.kotlin.android` from 2.0.0 to 2.0.10 Updates `org.jetbrains.kotlin.plugin.serialization` from 2.0.0 to 2.0.10 Updates `androidx.test.ext:junit` from 1.1.4 to 1.2.1 Updates `androidx.test:rules` from 1.5.0 to 1.6.1 Updates `androidx.test.espresso:espresso-core` from 3.5.0 to 3.6.1 Updates `androidx.appcompat:appcompat` from 1.5.1 to 1.7.0 Updates `com.android.tools.build:gradle` from 8.5.1 to 8.5.2 Updates `androidx.test.ext:junit` from 1.1.4 to 1.2.1 Updates `androidx.test:rules` from 1.5.0 to 1.6.1 Updates `androidx.test.espresso:espresso-core` from 3.5.0 to 3.6.1 Updates `androidx.appcompat:appcompat` from 1.5.1 to 1.7.0 Updates `com.android.tools.build:gradle` from 8.5.1 to 8.5.2 Updates `io.github.vvb2060.ndk:curl` from 8.8.0 to 8.9.1-lto-ndk27 - [Release notes](https://github.com/vvb2060/curl-android/releases) - [Commits](https://github.com/vvb2060/curl-android/commits) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-test dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: androidx.annotation:annotation dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.lint:lint dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.lint:lint-api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.lint:lint-checks dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.lint:lint-tests dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.lint:lint-api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.lint:lint-checks dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.lint:lint-tests dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: com.android.tools.build:gradle dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: org.jetbrains.kotlin.android dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: androidx.test.ext:junit dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: androidx.test:rules dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: androidx.test.espresso:espresso-core dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: androidx.appcompat:appcompat dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: com.android.tools.build:gradle dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: androidx.test.ext:junit dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: androidx.test:rules dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: androidx.test.espresso:espresso-core dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: androidx.appcompat:appcompat dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: com.android.tools.build:gradle dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: io.github.vvb2060.ndk:curl dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>

github-actions · 2024-08-12T13:47:54Z

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2714-compared-to-main.txt

github-actions · 2024-08-12T14:09:18Z

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2714-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.0Mi  +420% +25.1Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2714-compared-to-legacy.txt

github-actions · 2024-08-12T14:11:55Z

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0290         +0.0293             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2714-compared-to-main.txt

dependabot bot and others added 2 commits August 12, 2024 05:34

Update Android dependencies

2fe8e20

louwers added the android label Aug 12, 2024

louwers requested review from artakka and cgalvan August 12, 2024 12:45

louwers self-assigned this Aug 12, 2024

louwers added the dependencies Pull requests that update a dependency file label Aug 12, 2024

Replace mapbox-gestures-android with maplibre-gestures-android

eac5ba2

louwers changed the title ~~Update Android Dependencies~~ Update Android Dependencies, use maplibre-gestures-android Aug 16, 2024

louwers added 9 commits August 16, 2024 14:21

Remove supportAppcompatV7 dependency render test app

e7ef63c

Remove appcompatactivity

b59dba3

ignore update

e97ea48

Remove androidx.appcompat from test app

7767c81

Don't over-specify coroutines version

a1506e9

Delete unused script

9f8b597

Use jvmToolchain

2933f47

Update NDK render test app

3471bbb

Try to fix build

0de8468

louwers linked an issue Aug 19, 2024 that may be closed by this pull request

Use JVM Toolchain #2726

Closed

cgalvan approved these changes Aug 19, 2024

View reviewed changes

louwers merged commit c3a2fa2 into maplibre:main Aug 19, 2024
38 checks passed

louwers deleted the android-deps branch August 19, 2024 19:08

ganfra mentioned this pull request Aug 28, 2024

Android R8 minimize fails with android-v11.2.0 maplibre/maplibre-plugins-android#64

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Android Dependencies, use maplibre-gestures-android #2714

Update Android Dependencies, use maplibre-gestures-android #2714

louwers commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

Update Android Dependencies, use maplibre-gestures-android #2714

Update Android Dependencies, use maplibre-gestures-android #2714

Conversation

louwers commented Aug 12, 2024 • edited Loading

github-actions bot commented Aug 12, 2024 • edited Loading

Bloaty Results (iOS) 🐋

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2714-compared-to-main.txt

github-actions bot commented Aug 12, 2024 • edited Loading

Bloaty Results 🐋

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2714-compared-to-main.txt

github-actions bot commented Aug 12, 2024 • edited Loading

louwers commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading