Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NDK version to 27.0.12077973, replace ALooper_pollAll with ALooper_pollOnce #2663

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Jul 30, 2024

  • Replaces deprecated ALooper_pollAll with ALooper_pollOnce .
  • Moves -Wno-deprecated-declarations from the source file to the build config (for UTF conversions).
  • Bump NDK version to 27.0.12077973

@louwers louwers self-assigned this Jul 30, 2024
Copy link

github-actions bot commented Jul 30, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -8  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2663-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.7Mi  +411% +24.6Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2663-compared-to-legacy.txt

Copy link

github-actions bot commented Jul 30, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0014         +0.0014             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2663-compared-to-main.txt

Copy link

github-actions bot commented Aug 1, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%     -32  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2663-compared-to-main.txt

@louwers louwers changed the title Bump NDK version to 27.0.12077973 Bump NDK version to 27.0.12077973, replace ALooper_pollAll with ALooper_pollOnce Aug 1, 2024
@louwers louwers requested review from cgalvan and mwilsnd August 1, 2024 16:55
@louwers louwers merged commit 88993b9 into maplibre:main Aug 1, 2024
37 checks passed
@louwers louwers deleted the bump-ndk branch August 1, 2024 18:12
bilal614 pushed a commit to bilal614/maplibre-native that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants