-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TaggedScheduler, couple lifetime of tasks and orchestrator #2398
Conversation
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2398-compared-to-main.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2398-compared-to-main.txt |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2398-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2398-compared-to-legacy.txt |
a518a05
to
9e31738
Compare
Should probably undo #2455 |
It'll disappear in the merge, that code was removed. |
9e31738
to
4e71b38
Compare
4e71b38
to
82a1c18
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean.
If there will be a new release or beta/alpha release with this change, we could test if it solves #2410 |
Thank you, I already added it to the branch and asked if it can still be reproduced: streetcomplete/StreetComplete#5693 (comment) |
This PR refactors the scheduler and thread pool architecture by coupling scheduled tasks with an opaque identifier intended to represent the owner of the submitted task. This enables queries on the thread pool based on tasks submitted by a specific owner, which is relevant as the same background thread pool can be shared among multiple map instances. Knowing what tasks are scheduled by a specific owner allows us to remove any timeout conditions when waiting on all submitted work to be completed. This should result in more consistent and deterministic behavior of background tasks in multiple map scenarios.