-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill outline triangulated reorganized #2266
Merged
alexcristici
merged 8 commits into
maplibre:main
from
alexcristici:fill-outline-triangulated-reorganized
Apr 16, 2024
Merged
Fill outline triangulated reorganized #2266
alexcristici
merged 8 commits into
maplibre:main
from
alexcristici:fill-outline-triangulated-reorganized
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcristici
requested review from
stefankarschti,
mwilsnd,
TimSylvester,
sjg-wdw,
louwers and
cgalvan
April 15, 2024 20:19
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2266-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2266-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2266-compared-to-main.txt |
mwilsnd
reviewed
Apr 15, 2024
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2266-compared-to-main.txt |
stefankarschti
approved these changes
Apr 16, 2024
Merged
mwilsnd
approved these changes
Apr 16, 2024
louwers
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line Basic
renamed toFill Outline Triangulated
and moved to fill layer, because it's replacingFill Outline
on Metal.OutlineDrawableTweaker
removed and used existingFillLayerTweaker
with new typeFillOutlineTriangulated
.This will enable some fill UBOs to be moved to layer level in the follow up PR.