Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill outline triangulated reorganized #2266

Merged

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented Apr 15, 2024

Line Basic renamed to Fill Outline Triangulated and moved to fill layer, because it's replacing Fill Outline on Metal.
OutlineDrawableTweaker removed and used existing FillLayerTweaker with new type FillOutlineTriangulated.
This will enable some fill UBOs to be moved to layer level in the follow up PR.

@alexcristici alexcristici self-assigned this Apr 15, 2024
@alexcristici alexcristici marked this pull request as ready for review April 15, 2024 20:19
Copy link

github-actions bot commented Apr 15, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +7.52Ki  +0.0% +1.38Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2266-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +20% +23.4Mi  +406% +24.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2266-compared-to-legacy.txt

Copy link

github-actions bot commented Apr 15, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0028         -0.0027             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2266-compared-to-main.txt

Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +68.5Ki  +0.4% +64.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2266-compared-to-main.txt

@alexcristici alexcristici merged commit 8264a1c into maplibre:main Apr 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants