Support for RTL text plugin 0.3.0 #4860
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
==========================================
+ Coverage 87.66% 88.00% +0.33%
==========================================
Files 265 265
Lines 37937 37946 +9
Branches 2407 2409 +2
==========================================
+ Hits 33257 33393 +136
+ Misses 3608 3495 -113
+ Partials 1072 1058 -14 ☔ View full report in Codecov by Sentry. |
| expect(workerResult.pluginURL).toBe(originalUrl); | ||
| }); | ||
|
|
||
| test('should do a full cycle of rtl loading synchronously', async () => { |
There was a problem hiding this comment.
This is how 0.2.3 works
| expect(workerResult.pluginURL).toBe(originalUrl); | ||
| }); | ||
|
|
||
| test('should do a full cycle of rtl loading asynchronously', async () => { |
There was a problem hiding this comment.
This is how 0.3.0 works.
I've added both tests to make sure both option will be supported in the future.
src/source/geojson_source.test.ts
Outdated
| @@ -302,6 +302,7 @@ describe('GeoJSONSource#update', () => { | |||
| })); | |||
|
|
|||
| test('forwards Supercluster options with worker request, ignore max zoom of source', () => new Promise<void>(done => { | |||
| jest.spyOn(console, 'warn').mockImplementation(() => {}); | |||
There was a problem hiding this comment.
This seems unrelated to this PR, maybe we should move it to another cleanup PR?
src/ui/camera.test.ts
Outdated
| @@ -3502,7 +3502,6 @@ describe('#flyTo globe projection', () => { | |||
| }); | |||
|
|
|||
| camera.on('moveend', () => { | |||
| console.log(leastZoom); | |||
There was a problem hiding this comment.
Same as the previous message. I'd leave only the RTL text plugin changes to this PR and move all these things to a test cleanup PR
Launch Checklist
Fixes #4850
CHANGELOG.mdunder the## mainsection.