Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pitch > 90 degrees #4851

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

Pitch > 90 degrees #4851

wants to merge 69 commits into from
+897 −79

Commits on Oct 22, 2024

  1. squashed changes to support pitch > 90

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ae4b5f0 View commit details
    Browse the repository at this point in the history

  2. fix merge conflicts

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    47a7bfe View commit details
    Browse the repository at this point in the history

  3. fix changelog screwup

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bbec26f View commit details
    Browse the repository at this point in the history

  4. fix lint and adjust build size

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2f9bba7 View commit details
    Browse the repository at this point in the history

  5. better naming

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    979d50b View commit details
    Browse the repository at this point in the history

  6. remove jumpToLLA (it can be made a plugin)

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    01168fe View commit details
    Browse the repository at this point in the history

  7. fix render tests by breaking camera-centric behavior

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bd328f8 View commit details
    Browse the repository at this point in the history

  8. better naming

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f0fa729 View commit details
    Browse the repository at this point in the history

  9. add setRoll operation

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9c08ab5 View commit details
    Browse the repository at this point in the history

  10. fix pitch95 render test

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    755bac0 View commit details
    Browse the repository at this point in the history

  11. add pitch=90 roll=135 render test

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    849bfd8 View commit details
    Browse the repository at this point in the history

  12. add render test for pitch95 with terrain

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6166780 View commit details
    Browse the repository at this point in the history

  13. test getMercatorHorizon() at high pitch

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a29b756 View commit details
    Browse the repository at this point in the history

  14. add test for recalculateZoomAndCenter without terrain

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e1c614e View commit details
    Browse the repository at this point in the history

  15. documentation

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    326da7c View commit details
    Browse the repository at this point in the history

  16. <89 -> <=89

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4abf0ef View commit details
    Browse the repository at this point in the history

  17. LLA -> LngLatAlt

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    13cef84 View commit details
    Browse the repository at this point in the history

  18. fix lint

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    543de87 View commit details
    Browse the repository at this point in the history

  19. Merc -> Mercator

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f6de410 View commit details
    Browse the repository at this point in the history

  20. add public API function setCenterElevation(), and remove render test … 

    …modification
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    632b0e9 View commit details
    Browse the repository at this point in the history

  21. don't let camera distances go negative

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5282903 View commit details
    Browse the repository at this point in the history

  22. change the mercator horizon heuristic to be continuous, and update re… 

    …nder tests.
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c05922e View commit details
    Browse the repository at this point in the history

  23. function to only set elevation if center point is below horizon

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1009103 View commit details
    Browse the repository at this point in the history

  24. update sky render tests

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b63efe3 View commit details
    Browse the repository at this point in the history

  25. update changelog

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7744196 View commit details
    Browse the repository at this point in the history

  26. revert unintended package changes.

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cb5b217 View commit details
    Browse the repository at this point in the history

  27. revert unnecessarry shader change

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    db0c48b View commit details
    Browse the repository at this point in the history

  28. updated maxPitch docs

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    074d23c View commit details
    Browse the repository at this point in the history

  29. fix spelling 

    Co-authored-by: Harel M <[email protected]>
    @NathanMOlson @HarelM
    NathanMOlson and HarelM committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    427d60e View commit details
    Browse the repository at this point in the history

  30. add named constant maxMercatorHorizonAngle

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bf1cafb View commit details
    Browse the repository at this point in the history

  31. use roll and pitch spec definitions in sky render tests

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    063f369 View commit details
    Browse the repository at this point in the history

  32. move __setElevationIfCenterPointBelowHorizon() from Transform to Map

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a6d4ca8 View commit details
    Browse the repository at this point in the history

  33. change mercator horizon limit from 89 to 89.25, so that horizon heuri… 

    …stic is unchanged below the old maximumpitch angle of 85 degrees.
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4f1910a View commit details
    Browse the repository at this point in the history

  34. update comment

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    49154f2 View commit details
    Browse the repository at this point in the history

  35. fix lint

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8ed693a View commit details
    Browse the repository at this point in the history

  36. update unit tests for new horizon heuristic

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fb56306 View commit details
    Browse the repository at this point in the history

  37. revert unchanged render test results

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e74742b View commit details
    Browse the repository at this point in the history

  38. add switch to control "centerClampedToGround" behavior

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    df84588 View commit details
    Browse the repository at this point in the history

  39. fix render tests

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fcedf46 View commit details
    Browse the repository at this point in the history

  40. Update src/geo/projection/mercator_utils.ts

    @HarelM @NathanMOlson
    HarelM authored and NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3cd4fb4 View commit details
    Browse the repository at this point in the history

  41. Apply suggestions from code review

    @HarelM @NathanMOlson
    HarelM authored and NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5ec7e2a View commit details
    Browse the repository at this point in the history

  42. Update src/geo/transform_interface.ts

    @HarelM @NathanMOlson
    HarelM authored and NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    795e293 View commit details
    Browse the repository at this point in the history

  43. Don't update center point if there is nothing to do (this was causing… 

    … issues with mouse pitch control at high pitch)
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c7d4b6e View commit details
    Browse the repository at this point in the history

  44. Add an example showing center point at the top of a building and pitc… 

    …h > 90
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    091519d View commit details
    Browse the repository at this point in the history

  45. remove warnings about pitch angles > 60.

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3b4a8eb View commit details
    Browse the repository at this point in the history

  46. move cameraMercatorCoordinateFromCenterAndRotation() to mercator_utils

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4cb0ed0 View commit details
    Browse the repository at this point in the history

  47. Restore old setLocationAtPoint(). This fixes unit tests but breaks `c… 

    …enter-point` example :(
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0e2f578 View commit details
    Browse the repository at this point in the history

  48. better unit test coverage and documentation for calculateCenterFromCa… 

    …meraLngLatAlt()
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fd2b16d View commit details
    Browse the repository at this point in the history

  49. add @internal

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4a05a11 View commit details
    Browse the repository at this point in the history

  50. code cleanup

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1424b35 View commit details
    Browse the repository at this point in the history

  51. Add calculateCameraOptionsFromCameraLngLatAltRotation() and unit tests

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    32a38ce View commit details
    Browse the repository at this point in the history

  52. add developer guide describing center point.

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fb95cd4 View commit details
    Browse the repository at this point in the history

  53. move high-pitch render tests to high-pitch folder

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2aadaeb View commit details
    Browse the repository at this point in the history

  54. fix build

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7ab857a View commit details
    Browse the repository at this point in the history

  55. update high pitch + terrain render test to remove setPitch() call

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ba54703 View commit details
    Browse the repository at this point in the history

  56. use transform's elevation in setLocationAtPoint()

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    95ba6d8 View commit details
    Browse the repository at this point in the history

  57. fix jumps when using the mouse to rotate past 90 degrees pitch

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4edc371 View commit details
    Browse the repository at this point in the history

  58. further safety against numerical issues near the horizon

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    338c78b View commit details
    Browse the repository at this point in the history

  59. fix spelling

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e71e8a8 View commit details
    Browse the repository at this point in the history

  60. make centerClampedToGround get/set symmetric

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    24c556d View commit details
    Browse the repository at this point in the history

  61. split recalculateZoomAndCenter unit tests.

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d19f03b View commit details
    Browse the repository at this point in the history

  62. simplify center-point example

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0b89d1e View commit details
    Browse the repository at this point in the history

  63. add examples for calculateCameraOptionsFromTo() and calculateCameraOp… 

    …tionsFromCameraLngLatAltRotation()
    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6eefb1e View commit details
    Browse the repository at this point in the history

  64. origPixelPerMeter -> originalPixelPerMeter

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    05b2a51 View commit details
    Browse the repository at this point in the history

  65. whitespace

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d71eb08 View commit details
    Browse the repository at this point in the history

  66. simplify center-point example

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    16a2103 View commit details
    Browse the repository at this point in the history

  67. set minZoom in example so we don't lose the map

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a71983e View commit details
    Browse the repository at this point in the history

  68. remove unnecessary limit on _farZ

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7f1a442 View commit details
    Browse the repository at this point in the history

  69. change pseudocode to Typescript

    @NathanMOlson
    NathanMOlson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a5cf6fa View commit details
    Browse the repository at this point in the history