Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix level of detail at high pitch #4750

Closed
wants to merge 30 commits into from
Closed

Fix level of detail at high pitch #4750

wants to merge 30 commits into from

Commits on Sep 23, 2024

  1. add failing unit tests to demonstrate issue #

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    af682a7 View commit details
    Browse the repository at this point in the history

  2. fix failing unit tests

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e04efc4 View commit details
    Browse the repository at this point in the history

  3. formatting

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    396464e View commit details
    Browse the repository at this point in the history

  4. better calculation of distanceZ

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bbfa12a View commit details
    Browse the repository at this point in the history

  5. update globe transform to calculate zoom level for each individual ti… 

    …le, updated unit test with large pitch angle to match new behavior
    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ed09a92 View commit details
    Browse the repository at this point in the history

  6. match behavior from globe to mercator

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f13b4ef View commit details
    Browse the repository at this point in the history

  7. update changelog

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3aa725d View commit details
    Browse the repository at this point in the history

  8. fix distance units

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0ee1c32 View commit details
    Browse the repository at this point in the history

  9. code hygiene

    @NathanMOlson
    NathanMOlson committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8a1c9ed View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fix source_cache unit tests (fix "overscaled" behavior)

    @NathanMOlson
    NathanMOlson committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e3b54e7 View commit details
    Browse the repository at this point in the history

  2. fix degrees vs radians

    @NathanMOlson
    NathanMOlson committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    24ecd8c View commit details
    Browse the repository at this point in the history

  3. load lower resolution tiles for terrain, based on parameter deltaZoom

    @NathanMOlson
    NathanMOlson committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    53f42b6 View commit details
    Browse the repository at this point in the history

  4. fix failing unit test (caused by radians vs degrees fix)

    @NathanMOlson
    NathanMOlson committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5aa3595 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. update terrain shading results

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3efe1b2 View commit details
    Browse the repository at this point in the history

  2. update test results for failing render tests

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8173270 View commit details
    Browse the repository at this point in the history

  3. update terrain/default render test

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    21ae70e View commit details
    Browse the repository at this point in the history

  4. upadte terrain heatmap render test

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6f9bad8 View commit details
    Browse the repository at this point in the history

  5. fix globe raster-pole e render test by re-incorporating tileSize into… 

    … zoom calculations
    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    22305b6 View commit details
    Browse the repository at this point in the history

  6. fix checkerboard render test, which was failing due to a very slight … 

    …shift in the z-boundary between tiles (now z8 tiles are used when the requested zoom is in approximately [7.94, 8.94) instead of [8.0, 9.0).)
    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d125e59 View commit details
    Browse the repository at this point in the history

  7. aded failing unit test for overscaled tiles

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dfcbf2a View commit details
    Browse the repository at this point in the history

  8. fix unit test with z < 0

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    04f52e2 View commit details
    Browse the repository at this point in the history

  9. fix render test "projection/globe/collision-text-variable-anchor/pitc… 

    …hed". I am not sure what the actual problem is, but it seems to have something to do with globeCoveringTiles() returning tiles that don't match the zoom level returned by globeCoveringZoom(). So we don't do that at low zoom levels.
    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b00ad1d View commit details
    Browse the repository at this point in the history

  10. code hygiene

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    49a9c41 View commit details
    Browse the repository at this point in the history

  11. add test that shows zoom levels at high pitch in terrain

    @NathanMOlson
    NathanMOlson committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    756b26b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. actual ptich was limited to 60 degrees, so set it to 60 for clarity

    @NathanMOlson
    NathanMOlson committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8730631 View commit details
    Browse the repository at this point in the history

  2. code hygiene

    @NathanMOlson
    NathanMOlson committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7ec03f4 View commit details
    Browse the repository at this point in the history

  3. remove osm tiles in terrain render tests and replace with number tiles

    @NathanMOlson
    NathanMOlson committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5830405 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. fix hardcoded terrain tileSize

    @NathanMOlson
    NathanMOlson committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9e6c0be View commit details
    Browse the repository at this point in the history

  2. fix unit test

    @NathanMOlson
    NathanMOlson committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8b01384 View commit details
    Browse the repository at this point in the history

  3. Add parameter to change tile selection behavior at high pitch

    @NathanMOlson
    NathanMOlson committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4f58b3b View commit details
    Browse the repository at this point in the history