map.getStyle() modification issue #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4488 +/- ##
===========================================
- Coverage 87.82% 65.36% -22.46%
===========================================
Files 247 247
Lines 33492 33493 +1
Branches 2234 1780 -454
===========================================
- Hits 29413 21892 -7521
- Misses 3070 10758 +7688
+ Partials 1009 843 -166 ☔ View full report in Codecov by Sentry. |
gavinr-maps
force-pushed
the
4481-getstyle-modify-style-issue
branch
from
bc98595
to
db7bb1c
Compare
gavinr-maps
force-pushed
the
4481-getstyle-modify-style-issue
branch
from
db7bb1c
to
fe7957b
Compare
to ensure the value cannot be written by the user
…y-style-issue # Conflicts: # CHANGELOG.md
gavinr-maps
changed the title
HarelM
reviewed
Aug 1, 2024
HarelM
reviewed
Aug 1, 2024
|
Thanks for taking the time to open this PR! |
per PR feedback
|
@HarelM thank you for the feedback and your time maintaining this project. I have addressed your feedback and is ready for your re-review when you have some time. Thanks. |
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Sep 22, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [maplibre-gl](https://maplibre.org/) ([source](https://github.com/maplibre/maplibre-gl-js)) | dependencies | minor | [`4.5.2` -> `4.7.0`](https://renovatebot.com/diffs/npm/maplibre-gl/4.5.2/4.7.0) | --- ### Release Notes <details> <summary>maplibre/maplibre-gl-js (maplibre-gl)</summary> ### [`v4.7.0`](https://github.com/maplibre/maplibre-gl-js/blob/HEAD/CHANGELOG.md#470) [Compare Source](maplibre/maplibre-gl-js@v4.6.0...v4.7.0) ##### ✨ Features and improvements - Support multiple layers in `map.on`, `map.once` and `map.off` methods ([#​4570](maplibre/maplibre-gl-js#4570)) - Ensure GeoJSON cluster sources emit a console warning if `maxzoom` is less than or equal to `clusterMaxZoom` since in this case you may see unexpected results. ([#​4604](maplibre/maplibre-gl-js#4604)) ##### 🐞 Bug fixes - Heatmap Fix for 3D terrain ([#​4571](maplibre/maplibre-gl-js#4571)) - Fix Map#off to not remove listener with layer(s) registered with Map#once ([#​4592](maplibre/maplibre-gl-js#4592)) - Improve types a bit for `addSource` and `getSource` ([#​4616](maplibre/maplibre-gl-js#4616)) - Fix the color near the horizon when terrain is enabled without any sky ([#​4607](maplibre/maplibre-gl-js#4607)) - Fix bug where `fitBounds` and `cameraForBounds` would not display across the 180th meridian (antimeridian) - Fix white flickering on map resize ([#​4158](maplibre/maplibre-gl-js#4158)) - Fixed a performance regression related to symbol placement ([#​4599](maplibre/maplibre-gl-js#4599)) - Fix a bug where cloning a Transform instance didn't include the `lngRange`. This caused a bug where using `transformCameraUpdate` caused the `maxBounds` to stop working just for east/west bounds. ([#​4625](maplibre/maplibre-gl-js#4625)) ### [`v4.6.0`](https://github.com/maplibre/maplibre-gl-js/blob/HEAD/CHANGELOG.md#460) [Compare Source](maplibre/maplibre-gl-js@v4.5.2...v4.6.0) ##### ✨ Features and improvements - Prefer local glyph rendering for all CJKV characters, not just those in the CJK Unified Ideographs, Hiragana, Katakana, and Hangul Syllables blocks. ([#​4560](maplibre/maplibre-gl-js#4560))) ##### 🐞 Bug fixes - Fix right-to-left layout of labels that contain characters in the Arabic Extended-B code block. ([#​4536](maplibre/maplibre-gl-js#4536)) - Fix 3D map freezing when camera is adjusted against map bounds. ([#​4537](maplibre/maplibre-gl-js#4537)) - Fix `getStyle()` to return a clone so the object cannot be internally changed ([#​4488](maplibre/maplibre-gl-js#4488)) - Fix issues with setting sky to `undefined` ([#​4587](maplibre/maplibre-gl-js#4587))) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC40Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguODYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/52 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change returns a clone of the object so that when calling
.getStyle()the user cannot inadvertently modify the internally stored style.Launch Checklist
CHANGELOG.mdunder the## mainsection.