-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4340] Fixes possible access to undefined object #4431
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4431 +/- ##
==========================================
+ Coverage 87.57% 87.79% +0.22%
==========================================
Files 246 246
Lines 33396 33396
Branches 2223 2184 -39
==========================================
+ Hits 29247 29321 +74
+ Misses 3130 3076 -54
+ Partials 1019 999 -20 ☔ View full report in Codecov by Sentry. |
Any chance you could create a unit test to cover this scenario? |
@HarelM I have added the test. I also got a better idea, why the problem happened — when a new It makes me think, perhaps there is a larger problem, and in the perfect world, something should be synchronized better, so that the style is not set on the map before the style is loaded, or render() is not called before the map style is loaded... but regardless, my PR hotfixes the problem with library crashing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS
Fixes regression in the latest v4.5.0 release —
Fixes #4340.
Launch Checklist
CHANGELOG.md
under the## main
section.