Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flicker on map resize #4429

Closed
wants to merge 9 commits into from
Closed

Fix flicker on map resize #4429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f40d038
fix map flicker on resize
daylightwarbler Jul 18, 2024
d91c70b
update changelog
daylightwarbler Jul 18, 2024
ba131a4
update changelog with pr #
daylightwarbler Jul 18, 2024
b9320d5
Merge branch 'main' into resize-flicker
HarelM Aug 1, 2024
b2ec00e
Merge branch 'main' into resize-flicker
birkskyum Aug 5, 2024
052068b
Update CHANGELOG.md
HarelM Aug 6, 2024
44fce8c
Merge branch 'main' into resize-flicker
HarelM Aug 6, 2024
29d57d3
switch to simpler triggerRepaint call
daylightwarbler Aug 6, 2024
f2ee69c
Revert "switch to simpler triggerRepaint call"
daylightwarbler Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

### 🐞 Bug fixes
- Fix camera being able to move into 3D terrain ([#1542](https://github.com/maplibre/maplibre-gl-js/issues/1542))
- Fix flicker on map resize ([#4429](https://github.com/maplibre/maplibre-gl-js/pull/4429))
- _...Add new stuff here..._

## 4.5.1
Expand Down
1 change: 1 addition & 0 deletions src/ui/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,7 @@ export class Map extends Camera {
const throttledResizeCallback = throttle((entries: ResizeObserverEntry[]) => {
if (this._trackResize && !this._removed) {
this.resize(entries)._update();
this._render(Date.now());
}
}, 50);
this._resizeObserver = new ResizeObserver((entries) => {
Expand Down