Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for distance style spec expression #4076

Merged
merged 4 commits into from
May 5, 2024
Merged

Add support for distance style spec expression #4076

merged 4 commits into from
May 5, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented May 4, 2024

Launch Checklist

Resolves #2077

This is in continue to:

Which basically added the support in the style spec.
This adds the support here (which doesn't need any changes).
I've added a render test to make sure this works as expected.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes. - See render test
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.60%. Comparing base (2055bf7) to head (1c7743d).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4076      +/-   ##
==========================================
+ Coverage   86.49%   86.60%   +0.11%     
==========================================
  Files         242      241       -1     
  Lines       32596    32541      -55     
  Branches     1989     2201     +212     
==========================================
- Hits        28194    28183      -11     
+ Misses       3443     3395      -48     
- Partials      959      963       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 743ca3d into main May 5, 2024
15 checks passed
@HarelM HarelM deleted the add-distance branch May 5, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unimplemented distance expression
3 participants