Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image sources not being marked as loaded on error #3981

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

tzetter
Copy link
Contributor

@tzetter tzetter commented Apr 11, 2024

Launch Checklist

This fixes image sources not being marked as loaded when loading of the image fails.

This behavior changed as a result of 859b1a7#diff-d4cf28d025bceded1ecd0f4b0b3095b831e34317b61f25611d3cf44e82d64c14 as the new try/catch approach doesn't change the _loaded variable on error.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@HarelM HarelM enabled auto-merge (squash) April 11, 2024 18:56
@HarelM HarelM merged commit d5569f2 into maplibre:main Apr 11, 2024
15 checks passed
@tzetter tzetter deleted the image-source-loaded-fix branch April 11, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants