Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.5.2 #3271

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Release 3.5.2 #3271

merged 1 commit into from
Oct 25, 2023

Conversation

rejas
Copy link
Contributor

@rejas rejas commented Oct 25, 2023

✨ Features and improvements

  • Convert plantuml diagrams to mermaid (#3217)
  • Improve buffer transfer in Safari after Safari fixed a memory leak bug (#3225)
  • Minify internal exports to reduce bundle size (#3216)

🐞 Bug fixes

  • Add terrain property to map style object (#3234)
  • Fix exception thrown from isWebGL2 check (#3238)
  • Fix rollup watch mode (#3270)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8f5ae1) 75.23% compared to head (3f3fc70) 75.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3271   +/-   ##
=======================================
  Coverage   75.23%   75.23%           
=======================================
  Files         241      241           
  Lines       19256    19256           
  Branches     4339     4339           
=======================================
  Hits        14488    14488           
  Misses       4768     4768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM enabled auto-merge (squash) October 25, 2023 09:32
@HarelM HarelM disabled auto-merge October 25, 2023 09:32
@HarelM HarelM enabled auto-merge (squash) October 25, 2023 09:32
@rejas
Copy link
Contributor Author

rejas commented Oct 25, 2023

So the failing test isnt a problem @HarelM ?

@HarelM HarelM merged commit ff348da into maplibre:main Oct 25, 2023
14 checks passed
@HarelM
Copy link
Collaborator

HarelM commented Oct 25, 2023

We have some flaky tests unfortunately, our attempt to understand what causes them to sometime fail wasn't successful unfortunately, currently we re-run them, which usually solve the issue.

@rejas
Copy link
Contributor Author

rejas commented Oct 25, 2023

We have some flaky tests unfortunately, our attempt to understand what causes them to sometime fail wasn't successful unfortunately, currently we re-run them, which usually solve the issue.

Ah yes, we have the same issue (flaky tests) over at https://github.com/MichMich/MagicMirror too.

@rejas rejas deleted the bump_version branch October 25, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants