Update Development Environment - Support Node v14

.circleci/config.yml

@@ -75,7 +75,7 @@ workflows:
 
 defaults: &defaults
   docker:
-    - image: circleci/node:10.16-browsers
+    - image: circleci/node:14.16-browsers
   working_directory: ~/mapbox-gl-js
 
 jobs:
@@ -85,10 +85,10 @@ jobs:
       - checkout
       - restore_cache:
           keys:
-            - v3-yarn-{{ checksum "yarn.lock" }}
+            - v4-yarn-{{ checksum "yarn.lock" }}
       - run: yarn
       - save_cache:
-          key: v3-yarn-{{ checksum "yarn.lock" }}
+          key: v4-yarn-{{ checksum "yarn.lock" }}
           paths:
             - '~/.yarn'
             - 'node_modules'

.eslintignore

@@ -0,0 +1,33 @@
+rollup/build/
+dist/*
+*.es.js
+*.js.map
+node_modules
+package-lock.json
+*.sublime-*
+coverage
+flow-coverage
+.DS_Store
+.nyc_output
+*_generated.js
+*_generated.js.map
+test/integration/**/index*.html
+test/integration/**/actual.png
+test/integration/**/actual.json
+test/integration/**/diff.png
+test/integration/**/test-results.xml
+test/integration/dist/**/*.js
+test/integration/dist/**/*.json
+.eslintcache
+src/style-spec/dist/index.js
+_batfish_site
+_batfish_tmp
+_site
+yarn-error.log
+yarn-debug.log
+npm-debug.log
+.idea
+*.iml
+
+bench/benchmarks_view.js
+test/build/style-spec.test.js

.eslintrc

@@ -4,9 +4,13 @@
     "plugin:flowtype/recommended",
     "plugin:import/recommended"
   ],
-  "parser": "babel-eslint",
+  "parser": "@babel/eslint-parser",
   "parserOptions": {
-    "sourceType": "module"
+    "sourceType": "module",
+    "requireConfigFile": false,
+    "babelOptions": {
+      "presets": ["@babel/preset-flow"]
+    }
   },
   "plugins": [
     "flowtype",
@@ -22,14 +26,21 @@
     "no-duplicate-imports": "off",
     "import/no-duplicates": "error",
 
-    // temporarily disabled for easier upgrading of dependencies
+    // compatibility with native ESM
+    "import/extensions": ["error", {
+      "js": "always",
+      "json": "always"
+    }],
+
     "implicit-arrow-linebreak": "off",
     "arrow-parens": "off",
     "arrow-body-style": "off",
     "no-confusing-arrow": "off",
     "no-control-regex": "off",
     "no-invalid-this": "off",
-    "no-buffer-constructor": "off",
+    "no-prototype-builtins": "off",
+    "accessor-pairs": "off",
+    "require-atomic-updates": "off",
 
     "array-bracket-spacing": "off",
     "consistent-return": "off",
@@ -72,7 +83,7 @@
         "parameters": "off"
       }
     }],
-    "no-multiple-empty-lines": [ "error", { 
+    "no-multiple-empty-lines": [ "error", {
         "max": 1
     }],
     "jsdoc/check-param-names": "warn",

.github/workflows/analyze.yml

@@ -18,10 +18,10 @@ jobs:
       # report status back to pull request
       - uses: haya14busa/action-workflow_run-status@v1
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       - name: Download branch artifact

.github/workflows/build.yml

@@ -12,10 +12,10 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       - run: yarn run build-prod-min

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
           - macos-latest
           - windows-latest
         node_version:
-          - 10
+          - 14
         architecture:
           - x64
 
@@ -42,10 +42,10 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       - run: yarn run lint
@@ -57,10 +57,10 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       - run: yarn run test-flow
@@ -70,10 +70,10 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       # see: https://github.com/stackgl/headless-gl#how-can-headless-gl-be-used-on-a-headless-linux-machine
@@ -84,10 +84,10 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       - run: yarn run test-query
@@ -105,10 +105,10 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       - run: yarn run test-expressions
@@ -120,10 +120,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2-beta
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
       - run: yarn install --frozen-lockfile
       - run: yarn run build-dev
@@ -146,10 +146,10 @@ jobs:
   #   needs: [build]
   #   steps:
   #     - uses: actions/checkout@v2
-  #     - name: Use Node.js 10 x64
+  #     - name: Use Node.js 14 x64
   #       uses: actions/setup-node@v2-beta
   #       with:
-  #         node-version: 10
+  #         node-version: 14
   #         architecture: x64
   #     - run: yarn install --frozen-lockfile
   #     - uses: actions/download-artifact@v2
@@ -166,10 +166,10 @@ jobs:
   # test-render:
   #   runs-on: ubuntu-latest
   #   steps:
-  # - name: Use Node.js 10 x64
+  # - name: Use Node.js 14 x64
   #   uses: actions/setup-node@v2-beta
   #   with:
-  #     node-version: 10
+  #     node-version: 14
   #     architecture: x64
   # - run: yarn install --frozen-lockfile
   #     - run: yarn run test-render

.github/workflows/release.yml

@@ -18,10 +18,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
           registry-url: 'https://registry.npmjs.org'
 
@@ -70,10 +70,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Use Node.js 10 x64
+      - name: Use Node.js 14 x64
         uses: actions/setup-node@v2
         with:
-          node-version: 10
+          node-version: 14
           architecture: x64
           registry-url: 'https://registry.npmjs.org'
 

.nvmrc

@@ -0,0 +1 @@
+14.16

CHANGELOG.md

@@ -3,6 +3,7 @@
 ### Features and improvements
 
 - *...Add new stuff here...*
+- Update development environment to support Node 14 (#190)
 
 ### 🐞 Bug fixes
 

bench/benchmarks/expressions.js

@@ -1,16 +1,16 @@
 // @flow
 
-import Benchmark from '../lib/benchmark';
+import Benchmark from '../lib/benchmark.js';
 
-import spec from '../../src/style-spec/reference/latest';
-import convertFunction from '../../src/style-spec/function/convert';
-import {isFunction, createFunction} from '../../src/style-spec/function';
-import {createPropertyExpression} from '../../src/style-spec/expression';
-import fetchStyle from '../lib/fetch_style';
+import spec from '../../src/style-spec/reference/latest.js';
+import convertFunction from '../../src/style-spec/function/convert.js';
+import {isFunction, createFunction} from '../../src/style-spec/function/index.js';
+import {createPropertyExpression} from '../../src/style-spec/expression/index.js';
+import fetchStyle from '../lib/fetch_style.js';
 
-import type {StyleSpecification} from '../../src/style-spec/types';
-import type {StylePropertySpecification} from '../../src/style-spec/style-spec';
-import type {StylePropertyExpression} from '../../src/style-spec/expression';
+import type {StyleSpecification} from '../../src/style-spec/types.js';
+import type {StylePropertySpecification} from '../../src/style-spec/style-spec.js';
+import type {StylePropertyExpression} from '../../src/style-spec/expression/index.js';
 
 class ExpressionBenchmark extends Benchmark {
     data: Array<{

bench/benchmarks/filter_create.js

@@ -1,8 +1,8 @@
 // @flow
 
-import Benchmark from '../lib/benchmark';
+import Benchmark from '../lib/benchmark.js';
 
-import createFilter from '../../src/style-spec/feature_filter';
+import createFilter from '../../src/style-spec/feature_filter/index.js';
 import filters from '../data/filters.json';
 
 export default class FilterCreate extends Benchmark {

bench/benchmarks/filter_evaluate.js

@@ -1,8 +1,7 @@
-
-import Benchmark from '../lib/benchmark';
+import Benchmark from '../lib/benchmark.js';
 import {VectorTile} from '@mapbox/vector-tile';
 import Pbf from 'pbf';
-import createFilter from '../../src/style-spec/feature_filter';
+import createFilter from '../../src/style-spec/feature_filter/index.js';
 import filters from '../data/filters.json';
 import assert from 'assert';
 

bench/benchmarks/hillshade_load.js

@@ -1,8 +1,8 @@
 // @flow
 
-import Benchmark from '../lib/benchmark';
-import createMap from '../lib/create_map';
-import type {StyleSpecification} from '../../src/style-spec/types';
+import Benchmark from '../lib/benchmark.js';
+import createMap from '../lib/create_map.js';
+import type {StyleSpecification} from '../../src/style-spec/types.js';
 
 export default class HillshadeLoad extends Benchmark {
     style: StyleSpecification;

bench/benchmarks/layers.js

@@ -1,6 +1,6 @@
 
-import Benchmark from '../lib/benchmark';
-import createMap from '../lib/create_map';
+import Benchmark from '../lib/benchmark.js';
+import createMap from '../lib/create_map.js';
 import style from '../data/empty.json';
 
 const width = 1024;

bench/benchmarks/layout.js

@@ -1,10 +1,10 @@
 // @flow
 
-import type {StyleSpecification} from '../../src/style-spec/types';
-import Benchmark from '../lib/benchmark';
-import fetchStyle from '../lib/fetch_style';
-import TileParser from '../lib/tile_parser';
-import {OverscaledTileID} from '../../src/source/tile_id';
+import type {StyleSpecification} from '../../src/style-spec/types.js';
+import Benchmark from '../lib/benchmark.js';
+import fetchStyle from '../lib/fetch_style.js';
+import TileParser from '../lib/tile_parser.js';
+import {OverscaledTileID} from '../../src/source/tile_id.js';
 
 export default class Layout extends Benchmark {
     tiles: Array<{tileID: OverscaledTileID, buffer: ArrayBuffer}>;

bench/benchmarks/layout_dds.js

@@ -1,8 +1,8 @@
 // @flow
 
-import Benchmark from '../lib/benchmark';
-import TileParser from '../lib/tile_parser';
-import {OverscaledTileID} from '../../src/source/tile_id';
+import Benchmark from '../lib/benchmark.js';
+import TileParser from '../lib/tile_parser.js';
+import {OverscaledTileID} from '../../src/source/tile_id.js';
 
 const LAYER_COUNT = 2;
 

bench/benchmarks/map_load.js

@@ -1,6 +1,6 @@
 
-import Benchmark from '../lib/benchmark';
-import createMap from '../lib/create_map';
+import Benchmark from '../lib/benchmark.js';
+import createMap from '../lib/create_map.js';
 
 export default class MapLoad extends Benchmark {
     bench() {

bench/benchmarks/paint.js

@@ -1,8 +1,8 @@
 // @flow
 
-import Benchmark from '../lib/benchmark';
-import createMap from '../lib/create_map';
-import type Map from '../../src/ui/map';
+import Benchmark from '../lib/benchmark.js';
+import createMap from '../lib/create_map.js';
+import type Map from '../../src/ui/map.js';
 
 const width = 1024;
 const height = 768;