Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish style spec v14.0.0 to NPM #149

Merged
merged 5 commits into from
May 4, 2021
Merged

Conversation

wipfli
Copy link
Contributor

@wipfli wipfli commented May 1, 2021

This pull request removes the --dry-run flag from the publish-style-spec.yml action.

You find the output of the last dry run here: #147 (comment)

If merged, we will be able to publish v13.17.0 of the style spec to NPM at @maplibre/maplibre-gl-style-spec.

  • ✅ confirm your changes do not include backports from Mapbox projects (unless with compliant license)
  • ✅ briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • 👍 apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • 👍 add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

Bundle size report:

Size Change: 0 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file Before After Change
maplibre-gl.js 196 kB 196 kB 0 B
maplibre-gl.css 8.87 kB 8.87 kB 0 B
ℹ️ View Details No major changes

@wipfli wipfli changed the title Publish style spec v13.17.0 to NPM Publish style spec v14.0.0 to NPM May 4, 2021
@wipfli
Copy link
Contributor Author

wipfli commented May 4, 2021

Since we remove the --mapbox-api-supported option of the gl-style-validate utility, I think we have to increase the major version by one, i.e. go to style spec v14.0.0.

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wipfli wipfli merged commit f3e1e3b into maplibre:main May 4, 2021
@wipfli wipfli deleted the publish-style-spec-4 branch May 4, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants