Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapDataEvent#isSourceLoaded is true when a "dataloading" event fires for a GeoJSONSource #694

Closed
vanilla-lake opened this issue Dec 3, 2021 · 3 comments
Closed

MapDataEvent#isSourceLoaded is true when a "dataloading" event fires for a GeoJSONSource #694

vanilla-lake opened this issue Dec 3, 2021 · 3 comments

Comments

@vanilla-lake
Copy link
Contributor

1.15.2:

Steps to Trigger Behavior

Call GeoJSONSource#setData(...) with a dataloading event listener registered.

Link to Demonstration

https://jsbin.com/bigupoyejo/2/edit?html,console

Expected Behavior

MapDataEvent#isSourceLoaded should be false when the dataloading event fires for the GeoJSON source.

Actual Behavior

MapDataEvent#isSourceLoaded is true when the dataloading event fires for the GeoJSON source.
vanilla-lake added a commit to vanilla-lake/maplibre-gl-js that referenced this issue Dec 3, 2021
@vanilla-lake
Fix MapDataEvent#isSourceLoaded being true in GeoJSONSource "dataload…
b1ecf14 
…ing" event handlers (maplibre#694)
@vanilla-lake vanilla-lake mentioned this issue Dec 3, 2021
Merged
5 tasks
HarelM pushed a commit that referenced this issue Dec 8, 2021
@vanilla-lake
Fix MapDataEvent#isSourceLoaded being true in GeoJSONSource "dataload…
1831fe1 
…ing" event handlers (#694) (#695)

* Fix MapDataEvent#isSourceLoaded being true in GeoJSONSource "dataloading" event handlers (#694)

* Add a unit test for when a GeoJSONSource dataloading event handler throws

* Remove try...catch around code firing "dataloading" event along with corresponding unit test

* Extract MapSourceDataType union
davenquinn added a commit to davenquinn/maplibre-gl-js that referenced this issue Dec 29, 2021
@davenquinn
Merge branch 'main' into pluggable-render
61fd24c 
* main: (98 commits)
  [Jest] Migrate `geojson_worker_source.test.js` (maplibre#731)
  Fix events being fired after Map#remove has been called when the WebGL context is lost and restored (maplibre#726) (maplibre#727)
  Define return type of getSource as possibly undefined (maplibre#724)
  Fix attibution controll (maplibre#668)
  Fix start-debug to watch ts files (maplibre#704)
  [Jest] Migrate `touch_zoom_rotate.test.js` (maplibre#721)
  [Jest] Migrate `requestRenderFrame.test.js` (maplibre#722)
  [Jest] Migrate `scroll_zoom.test.js` (maplibre#712)
  [Jest] Migrate `marker.test.js` (maplibre#696)
  [Jest] Migrate `mouse_rotate.test.js` (maplibre#711)
  [Jest] Migrate `keyboard.test.js` (maplibre#707)
  [Jest] Migrate `map_event.test.js` (maplibre#710)
  [Jest] Migrate `drag_rotate.test.js` (maplibre#709)
  Handle spies and call counts (maplibre#708)
  [Jest] Migrate `drag_pan.test.js` (maplibre#702)
  Add type for styleimagemissing event (maplibre#703)
  Fix MapDataEvent#isSourceLoaded being true in GeoJSONSource "dataloading" event handlers (maplibre#694) (maplibre#695)
  [Jest] Migrate `dblclick_zoom.test.js` (maplibre#697)
  [Jest] Migrate `popup.test.js` (maplibre#687)
  Fixed typo (maplibre#698)
  ...
@HarelM
Copy link
Collaborator

HarelM commented Feb 11, 2022

@vanilla-lake is this still an issue?

@vanilla-lake
Copy link
Contributor Author

I don't think so. It should have been fixed by PR #695.

@HarelM
Copy link
Collaborator

HarelM commented Feb 11, 2022

OK, thanks, closing for now. If this is still an issue please reopen.

@HarelM HarelM closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarelM @vanilla-lake