-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish first release to NPM: [email protected] #5
Comments
I'm lseelenbinder. |
I'm snickell |
@nyurik do you also have the @maplibre org on npm? It might make sense to namespace all our packages under an org, while this is slightly different from how mapbox does it, I suspect it'll result in more ease and consistency for us (I suspect mapbox created their package names before this was common practice) |
OK, I'm focused on building and releasing |
This PR contains a rough doc of the steps I was using to build maps-gl releases yesterday: |
I just published the first release candidate experiment to npm: Could folks give it a try and report back? |
I'd like to follow a release principle as follows:
In other words, to be a true successor to mapbox-gl v1.13, we should treat v1.13 as if it was a release WE made, and follow a deprecation schedule policy for all changes from that (including api renames from This will serve our users best, minimize disruption in their lives, and increase the number of people who "upgrade really quick and easy" vs wait and see. |
There are potentially legal considerations to discuss here. I don't think its immediately clear that we can't safely+legally support, e.g. |
UPDATE: I believe that the primary (only?) thing blocking us from being ready to release [email protected] is getting enough test reports that RC3 is working as a perfect replacement: https://www.npmjs.com/package/maplibre-gl/v/1.13.0-rc.3 So please test it everyone! It would also be great for v1.13.0 if @lseelenbinder put together an edit to the readme documenting briefly (assuming other people agree) to do responsible stewardship and aim for slow gradual api changes with advanced notice and deprecation policies moving forward. |
Before we do a final release, lets decide if we should either keep the Mapbox packaging structure (maplibre-gl as a top-level package, while smaller libraries namespaced under My personal preference is to keep the same pattern as Mapbox to simplify migration (files will be placed in the same node_modules depth, etc), but I'm ok if we decide to abandon it from the start. |
I felt like namespacing is a close call, so its only a mild preference on my part, and I see good arguments either way. For developer ergonomics, I think non-namespaced wins, and when in doubt "don't make changes now" :-) So I think I'm changing my vote to: stick with what we have now, non-namespaced |
There's some "easy to find other things from the same project" advantages to |
I propose the first stable release of GL JS to be 1.14.0 - as proposed in #95 and as in the meanwhile Mapbox did 1.13.1. |
@klokan I second that |
Agreed. |
Published at https://www.npmjs.com/package/maplibre-gl as 1.14.0 |
…fork Cross tile symbol index perf
Once all other work in the first release project is done, publish the resulting code to NPM.
I have created a placeholder maplibre-gl NPM package.
@MapLibre/core please let me know your NPM user names so you can be added to the list of maintainers there.
The text was updated successfully, but these errors were encountered: