Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent scheduling of windows with duplicate starting times (SC-13253) #50

Merged

Conversation

vbidin
Copy link
Contributor

@vbidin vbidin commented Aug 1, 2023

Addresses 3S issue #8

@shortcut-integration
Copy link

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

| contracts/MapleTokenProxy.sol:MapleTokenProxy contract |                 |       |        |        |         |
|--------------------------------------------------------|-----------------|-------|--------|--------|---------|
| Deployment Cost                                        | Deployment Size |       |        |        |         |
| 457692                                                 | 2222            |       |        |        |         |
| Function Name                                          | min             | avg   | median | max    | # calls |
| addModule                                              | 12702           | 32431 | 32045  | 117545 | 35      |
| balanceOf                                              | 1226            | 3028  | 1226   | 7726   | 38      |
| burn                                                   | 1416            | 11459 | 10111  | 21344  | 7       |
| decimals                                               | 1023            | 1023  | 1023   | 1023   | 8       |
| globals                                                | 1154            | 2091  | 1154   | 7654   | 16      |
| governor                                               | 6438            | 6438  | 6438   | 6438   | 1       |
| implementation                                         | 1111            | 1111  | 1111   | 1111   | 2       |
| isModule                                               | 1194            | 1194  | 1194   | 1194   | 4       |
| mint                                                   | 1416            | 17147 | 12800  | 38400  | 7       |
| name                                                   | 1842            | 1842  | 1842   | 1842   | 1       |
| removeModule                                           | 12612           | 24429 | 23363  | 68037  | 13      |
| setImplementation                                      | 7392            | 38147 | 11875  | 95174  | 3       |
| symbol                                                 | 1929            | 1929  | 1929   | 1929   | 1       |
| totalSupply                                            | 1028            | 1916  | 1028   | 3028   | 9       |
| transfer                                               | 3684            | 23955 | 26384  | 30084  | 7       |
| contracts/RecapitalizationModule.sol:RecapitalizationModule contract |                 |       |        |       |         |
|----------------------------------------------------------------------|-----------------|-------|--------|-------|---------|
| Deployment Cost                                                      | Deployment Size |       |        |       |         |
| 1013506                                                              | 5246            |       |        |       |         |
| Function Name                                                        | min             | avg   | median | max   | # calls |
| claim                                                                | 21739           | 31954 | 28634  | 45490 | 3       |
| claimable                                                            | 1652            | 2985  | 1652   | 5652  | 3       |
| lastClaimedTimestamp                                                 | 379             | 379   | 379    | 379   | 7       |
| lastClaimedWindowId                                                  | 336             | 336   | 336    | 336   | 63      |
| lastScheduledWindowId                                                | 391             | 891   | 391    | 2391  | 4       |
| schedule                                                             | 56282           | 68300 | 71305  | 71305 | 5       |
| windows                                                              | 699             | 1090  | 699    | 2699  | 312     |

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

LCOV of commit 70596c4 during CI #94

Summary coverage rate:
  lines......: 100.0% (87 of 87 lines)
  functions..: 100.0% (28 of 28 functions)
  branches...: no data found

Files changed coverage rate:
                                      |Lines       |Functions  |Branches    
  Filename                            |Rate     Num|Rate    Num|Rate     Num
  ==========================================================================
  contracts/RecapitalizationModule.sol| 100%     52| 100%    10|    -      0

* fix: update error messages from im to rm

* fix: rename test file
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

LCOV of commit c260e1e during CI #96

Summary coverage rate:
  lines......: 100.0% (87 of 87 lines)
  functions..: 100.0% (28 of 28 functions)
  branches...: no data found

Files changed coverage rate:
                                      |Lines       |Functions  |Branches    
  Filename                            |Rate     Num|Rate    Num|Rate     Num
  ==========================================================================
  contracts/RecapitalizationModule.sol| 100%     52| 100%    10|    -      0

@0xfarhaan 0xfarhaan merged commit 5960d4c into main Aug 2, 2023
11 checks passed
@0xfarhaan 0xfarhaan deleted the sc-13253-feature-mplv2-audit-fix-add-check-to-avoid-2-windows branch August 2, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants