Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose mint and burn (SC-12655 & SC-12656) #4

Merged
merged 2 commits into from
Jun 21, 2023
Merged

feat: Expose mint and burn (SC-12655 & SC-12656) #4

merged 2 commits into from
Jun 21, 2023

Conversation

JGcarv
Copy link
Contributor

@JGcarv JGcarv commented Jun 14, 2023 •
edited
Loading

Not sure if I like using a struct (nor calling it Module)

But this covers the base case for minting and burn.

NOTE: AFTER #2

@JGcarv JGcarv requested a review from vbidin June 14, 2023 19:46
@JGcarv JGcarv self-assigned this Jun 14, 2023
@JGcarv JGcarv requested a review from a team as a code owner June 14, 2023 19:46
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12655: [MPLv2] Expose mint function to be called via allowed module.

vbidin
vbidin requested changes Jun 15, 2023
View reviewed changes
contracts/MapleToken.sol Outdated Show resolved Hide resolved
contracts/interfaces/Interfaces.sol Outdated Show resolved Hide resolved
@JGcarv JGcarv force-pushed the sc-12655-feature-mplv2-expose-mint-function-to-be-called-via branch from 90726e0 to fa5a226 Compare June 16, 2023 17:02
@JGcarv JGcarv changed the base branch from feat/token to main June 16, 2023 17:03
@JGcarv JGcarv requested a review from vbidin June 16, 2023 17:04
@github-actions
Copy link

LCOV of commit 5a726dc during Forge Tests (PR) #36

Summary coverage rate:
  lines......: 100.0% (15 of 15 lines)
  functions..: 100.0% (9 of 9 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  contracts/MapleToken.sol     | 100%     13| 100%     8|    -      0
  contracts/MapleTokenProxy.sol| 100%      2| 100%     1|    -      0

@github-actions
Copy link

LCOV of commit 03b3739 during Forge Tests (PR) #37

Summary coverage rate:
  lines......: 100.0% (15 of 15 lines)
  functions..: 100.0% (9 of 9 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  contracts/MapleToken.sol     | 100%     13| 100%     8|    -      0
  contracts/MapleTokenProxy.sol| 100%      2| 100%     1|    -      0

vbidin
vbidin requested changes Jun 19, 2023
View reviewed changes
contracts/MapleToken.sol Show resolved Hide resolved
tests/MapleToken.t.sol Outdated Show resolved Hide resolved
tests/MapleToken.t.sol Show resolved Hide resolved
@github-actions
Copy link

LCOV of commit e434817 during Forge Tests (PR) #39

Summary coverage rate:
  lines......: 100.0% (15 of 15 lines)
  functions..: 100.0% (9 of 9 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  contracts/MapleToken.sol     | 100%     13| 100%     8|    -      0
  contracts/MapleTokenProxy.sol| 100%      2| 100%     1|    -      0

@JGcarv JGcarv requested a review from vbidin June 19, 2023 16:54
@JGcarv JGcarv force-pushed the sc-12655-feature-mplv2-expose-mint-function-to-be-called-via branch from e434817 to 51087f8 Compare June 19, 2023 17:28
@JGcarv JGcarv force-pushed the sc-12655-feature-mplv2-expose-mint-function-to-be-called-via branch from 51087f8 to 51226f0 Compare June 19, 2023 17:34
@github-actions
Copy link

LCOV of commit 51226f0 during Forge Tests (PR) #40

Summary coverage rate:
  lines......: 100.0% (15 of 15 lines)
  functions..: 100.0% (9 of 9 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  contracts/MapleToken.sol     | 100%     13| 100%     8|    -      0

@JGcarv JGcarv merged commit c329704 into main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbidin vbidin vbidin approved these changes

Assignees

@JGcarv JGcarv

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JGcarv @vbidin