Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add post-migration lifecycle test (SC-12974) #39

Merged
merged 2 commits into from
Jul 27, 2023
Merged

feat: Add post-migration lifecycle test (SC-12974) #39

merged 2 commits into from
Jul 27, 2023

Conversation

JGcarv
Copy link
Contributor

@JGcarv JGcarv commented Jul 26, 2023

No description provided.

@JGcarv JGcarv requested review from vbidin and 0xfarhaan July 26, 2023 12:51
@JGcarv JGcarv self-assigned this Jul 26, 2023
@JGcarv JGcarv requested a review from a team as a code owner July 26, 2023 12:51
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12974: [mplv2] Post Migration lifecycle test.

@github-actions
Copy link

LCOV of commit 2f7baf7 during CI #40

Summary coverage rate:
  lines......: 100.0% (87 of 87 lines)
  functions..: 100.0% (28 of 28 functions)
  branches...: no data found

Files changed coverage rate: n/a

vbidin
vbidin requested changes Jul 26, 2023
View reviewed changes
tests/e2e/MigrationAndLifecycle.t.sol Outdated Show resolved Hide resolved
tests/e2e/MigrationAndLifecycle.t.sol Show resolved Hide resolved
tests/e2e/MigrationAndLifecycle.t.sol Show resolved Hide resolved
tests/e2e/MigrationAndLifecycle.t.sol Outdated Show resolved Hide resolved
@github-actions
Copy link

LCOV of commit 3dcbcda during CI #42

Summary coverage rate:
  lines......: 100.0% (87 of 87 lines)
  functions..: 100.0% (28 of 28 functions)
  branches...: no data found

Files changed coverage rate: n/a

@JGcarv JGcarv requested a review from vbidin July 26, 2023 19:06
0xfarhaan
0xfarhaan approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@0xfarhaan 0xfarhaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done ser

@0xfarhaan 0xfarhaan merged commit ddda420 into main Jul 27, 2023
10 checks passed
@0xfarhaan 0xfarhaan deleted the sc-12974-feature-mplv2-post-migration-lifecycle-test branch July 27, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbidin vbidin vbidin approved these changes

@0xfarhaan 0xfarhaan 0xfarhaan approved these changes

Assignees

@JGcarv JGcarv

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JGcarv @vbidin @0xfarhaan