Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Audit Fix - remove ntp dependency (SC-13014) #21

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat: Audit Fix - remove ntp dependency (SC-13014) #21

merged 1 commit into from
Jul 10, 2023

Conversation

JGcarv
Copy link
Contributor

@JGcarv JGcarv commented Jul 6, 2023

As commented, removed the dependency of the NTP, both on the proxy and proxied side.

@JGcarv JGcarv requested a review from a team as a code owner July 6, 2023 14:44
@JGcarv JGcarv self-assigned this Jul 6, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #13014: [mplv2] Audit fix - Decouple MapleTokenProxy from NTP.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

LCOV of commit 0446e89 during Forge Tests (PR) #108

Summary coverage rate:
  lines......: 100.0% (79 of 79 lines)
  functions..: 96.4% (27 of 28 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  contracts/MapleToken.sol           | 100%     15| 100%     8|    -      0
  contracts/MapleTokenInitializer.sol| 100%      6| 100%     1|    -      0
  contracts/MapleTokenProxy.sol      | 100%     13| 100%     7|    -      0

0xfarhaan
0xfarhaan requested changes Jul 7, 2023
View reviewed changes
contracts/MapleToken.sol Outdated Show resolved Hide resolved
contracts/MapleTokenProxy.sol Outdated Show resolved Hide resolved
contracts/MapleTokenProxy.sol Outdated Show resolved Hide resolved
contracts/MapleTokenProxy.sol Outdated Show resolved Hide resolved
deluca-mike
deluca-mike approved these changes Jul 7, 2023
View reviewed changes
contracts/MapleTokenProxy.sol Outdated Show resolved Hide resolved
@JGcarv JGcarv requested a review from 0xfarhaan July 7, 2023 18:02
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

LCOV of commit b5a7a09 during Forge Tests (PR) #113

Summary coverage rate:
  lines......: 98.8% (79 of 80 lines)
  functions..: 96.4% (27 of 28 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  contracts/MapleToken.sol           | 100%     15| 100%     8|    -      0
  contracts/MapleTokenInitializer.sol| 100%      6| 100%     1|    -      0
  contracts/MapleTokenProxy.sol      | 100%     13| 100%     7|    -      0

@JGcarv JGcarv requested a review from deluca-mike July 7, 2023 18:06
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

LCOV of commit ca5d555 during Forge Tests (PR) #114

Summary coverage rate:
  lines......: 98.7% (76 of 77 lines)
  functions..: 96.4% (27 of 28 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  contracts/MapleToken.sol           | 100%     12| 100%     8|    -      0
  contracts/MapleTokenInitializer.sol| 100%      6| 100%     1|    -      0
  contracts/MapleTokenProxy.sol      | 100%     13| 100%     7|    -      0

vbidin
vbidin requested changes Jul 9, 2023
View reviewed changes
.gitmodules Show resolved Hide resolved
contracts/MapleToken.sol Show resolved Hide resolved
@vbidin vbidin self-requested a review July 10, 2023 13:19
@JGcarv JGcarv merged commit 9206427 into main Jul 10, 2023
2 checks passed
@JGcarv JGcarv deleted the sc-13014-decouple-ntp branch July 10, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbidin vbidin vbidin approved these changes

@0xfarhaan 0xfarhaan Awaiting requested review from 0xfarhaan

@deluca-mike deluca-mike Awaiting requested review from deluca-mike

Assignees

@JGcarv JGcarv

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JGcarv @vbidin @deluca-mike @0xfarhaan