Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add integration test for migrator (SC-12862) #16

Merged
merged 3 commits into from
Jul 3, 2023
Merged

feat: Add integration test for migrator (SC-12862) #16

merged 3 commits into from
Jul 3, 2023

Conversation

JGcarv
Copy link
Contributor

@JGcarv JGcarv commented Jun 28, 2023

No description provided.

@JGcarv JGcarv requested a review from vbidin June 28, 2023 14:19
@JGcarv JGcarv self-assigned this Jun 28, 2023
@JGcarv JGcarv requested a review from a team as a code owner June 28, 2023 14:19
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12862: [mplv2] Integration test with Migrator.

@github-actions
Copy link

LCOV of commit 147194f during Forge Tests (PR) #64

Summary coverage rate:
  lines......: 100.0% (59 of 59 lines)
  functions..: 100.0% (16 of 16 functions)
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit 09569e9 during Forge Tests (PR) #73

Summary coverage rate:
  lines......: 100.0% (59 of 59 lines)
  functions..: 100.0% (16 of 16 functions)
  branches...: no data found

Files changed coverage rate: n/a

vbidin
vbidin requested changes Jul 3, 2023
View reviewed changes
tests/integration/Migration.t.sol Outdated Show resolved Hide resolved
tests/utils/TestBase.sol Outdated Show resolved Hide resolved
tests/utils/CompilerResolver.sol Outdated Show resolved Hide resolved
tests/integration/Migration.t.sol Outdated Show resolved Hide resolved
tests/integration/Migration.t.sol Outdated Show resolved Hide resolved
tests/integration/Migration.t.sol Outdated Show resolved Hide resolved
tests/integration/Migration.t.sol Outdated Show resolved Hide resolved
@JGcarv JGcarv requested a review from vbidin July 3, 2023 22:28
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

LCOV of commit b04dcc5 during Forge Tests (PR) #95

Summary coverage rate:
  lines......: 100.0% (67 of 67 lines)
  functions..: 95.0% (19 of 20 functions)
  branches...: no data found

Files changed coverage rate: n/a

@JGcarv JGcarv merged commit a8fd95c into main Jul 3, 2023
@JGcarv JGcarv deleted the sc-12862--migrator-test branch July 3, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbidin vbidin vbidin approved these changes

Assignees

@JGcarv JGcarv

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JGcarv @vbidin