-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify maximum buffer #82
Comments
I would prefer SHOULD NOT since there have been requests for an option (tippecanoe's |
SHOULD NOT would be fine with me. |
For context, GL JS has been having some issues due to Mapnik encoding coordinate values equal to Adopting this new specification will allow renderer implementations to make confident and efficient choices about the data type used to represent coordinates. See mapbox/mapbox-gl-js#2568 for more information. |
👎 on MUST. I'm iffy on SHOULD NOT. I can understand the desire to know the maximum coordinate values from only parsing |
The specification absolutely can and does define constraints that reflect reasonable practical needs of software that consumes vector tiles. The practical needs of consumers were what drove the v2 push for defining winding order, polygon validity, and such; this is in the same category.
The specification doesn't list any error handling requirements for tiles that do not conform to MUST or SHOULD requirements, so it would be up the the implementation. |
Reading more on the expectations of MUST and SHOULD I'm wondering if this requirement needs to be MUST for interoperability reasons. |
[This is like https://github.com//issues/59, but getting at the actual implementation need in mapbox-gl.]
To ensure that implementations can make reasonable assumptions about the size of integers needed to store coordinate values for vector tiles of a given extent, the specification should place limits on how much buffering is permissible for a given extent.
Proposed change: in 4.1 replace
with
cc @flippmoke @lucaswoj @springmeyer @ericfischer
The text was updated successfully, but these errors were encountered: