Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Geometry exceeds allowed extent" warning from Mapbox tiles #2568

Closed
jfirebaugh opened this issue May 13, 2016 · 5 comments · Fixed by #2858
Closed

"Geometry exceeds allowed extent" warning from Mapbox tiles #2568

jfirebaugh opened this issue May 13, 2016 · 5 comments · Fixed by #2858
Assignees

Comments

@jfirebaugh
Copy link
Contributor

This warning is being triggered on data in Mapbox tiles.

To reproduce, npm start and load http://localhost:9966/#7.92/-0.176/0.063.

The layer is "marine-label-sm-ln", tile is https://a.tiles.mapbox.com/v4/mapbox.mapbox-terrain-v2,mapbox.mapbox-streets-v7/7/63/63.vector.pbf

@jfirebaugh
Copy link
Contributor Author

The offending x coordinate is 16384, one more than the EXTENT_MAX of 16383. I know there was some discussion of off-by-one errors in the original PR; looks like there's still some of these lurking in either this code or our VT generation code.

cc @yhahn @ansis

@yhahn yhahn self-assigned this May 13, 2016
@lucaswoj lucaswoj assigned lucaswoj and unassigned yhahn May 25, 2016
@lucaswoj
Copy link
Contributor

lucaswoj commented May 25, 2016

After a bit of digging, here is my understanding of the problem:

  • Mapnik supports buffer sizes up to and including the extent size
  • our marine label layer has a buffer size equal to its extent size
  • GL JS supports buffer sizes up to but not including the extent size (due to how we pack coordinates into our StructArrays)

The fix is to:

  • adjust how we pack coordinates into our StructArrays to allow the full range of allowed buffer sizes here
  • centralize our extent conversion math
  • clearly document our extent conversion math and add some light background on vector tile extents and buffers
  • port this change to GL Native

Thanks to @flippmoke and @ajashton for the help!

@gertcuykens
Copy link

gertcuykens commented Jun 28, 2016

When I zoom out fast enough at load time in streets-v8, I got allot of those errors?

PS Always performance above graphics please :P same as in video games :)

@geoangelotti
Copy link

For some reason i got this error when I had width="100%" height="100%" inside my MapGL component.

After removing it and assigning the height and width on the viewport the warning disappeared.

@natashaooh
Copy link

natashaooh commented Jan 24, 2020

I'm getting this error in the same situation as @geoangelotti, and I don't want to fall back to setting height in vh because it will mess up my layout. :( Does anyone have ideas on how to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants