add fillzoom #50
Merged
add fillzoom #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
springmeyer
reviewed
Jul 14, 2018
3.0.0/README.md
Outdated
|
|
||
| An integer specifying the zoom level at which to generate overzoomed tiles from. Implementations may generate overzoomed tiles from parent tiles if the requested zoom level does not exist. In most cases, overzoomed tiles are generated from the maximum zoom level of the tileset. If fillzoom is specified, the overzoomed tile is generated from the fillzoom level. | ||
|
|
||
| For example, in a tileset with maxzoom 10 and _no_ fillzoom specified, if a request for a z11 tile comes through, the implementation may use the maximum z10 parent tiles to generate the new, overzoomed z11 tile. If the same tilejson had fillzoom specified at z7, a request for a z11 tile could still try to generate with z10, but MAY backfill using to the z7 parent tile. |
There was a problem hiding this comment.
may use the maximum z10 -> will use the maximum z10 seems like more correct wording, unless you meant will try to use maximum z10 tile if it exists
I would say:
-If the same tilejson had fillzoom specified at z7, a request for a z11 tile could still try to generate with z10, but MAY backfill using to the z7 parent tile.
+If the same tilejson had fillzoom specified at z7, a request for a z11 tile would use the z7 tile instead of z10.I think the usecase here is for custom tile generation pipelines that want to have sparse tiling (avoid rendering to the maxzoom) for some regions, like large ocean regions.
There was a problem hiding this comment.
Awesome - thanks @springmeyer! fcf4ebb
springmeyer
approved these changes
Jul 14, 2018
|
Thanks @whyvez @springmeyer - appreciate your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
fillzoomfield, and should resolve #27cc @GretaCB