enable more warnings/make them errors per mapbox/cpp#37

[springmeyer]

Adding more default warnings (and making warnings errors) per mapbox/cpp#37

[springmeyer]

All done on the "enabling more warnings" side here. Now over to you @artemp, to decide how to fix the new warnings that have come up.

[artemp]

@springmeyer - all warnings fixed but g++ doesn't understand some compile flags, so over back to you :)

[springmeyer]

@artemp thank you - curious, why are some things throwing with throw std::runtime_error("Not implemented!"); (and therefore previously warning on unused args). Is this by design?

[artemp]

@springmeyer - yes, those structures are helpers allowing incomplete implementations (not all possible permutations of geometry types). This is intentional design feature to keep binary size under control. I'll take a look again to see if this mechanism can be implemented through meta-programming (compile time).

[springmeyer]

Okay, good to know @artemp - this would be great to document. How about you add a mention to the readme about this in design decision section?

[springmeyer]

@artemp okay, I pushed a fix to this branch so that we no longer apply -Wmost to g++ builds. Back to you again: the g++ builds are not emitting warnings on the code inside include/boost. Seems like we have two options to solve this. We could ignore the warnings from the vendered boost headers by doing:

- include_directories("${PROJECT_SOURCE_DIR}/include")
+ include_directories(SYSTEM "${PROJECT_SOURCE_DIR}/include/boost")
+ include_directories("${PROJECT_SOURCE_DIR}/include/mapbox")

Or we could fix the warnings. I noticed you've already modified the files inside include/boost. Which makes me lean towards treating these files as owned by this repo and therefore we should consider fixing the warnings?

[artemp]

@springmeyer - on my TODO list

[springmeyer]

Changes look great - thanks @artemp 🙌