-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests / port to tape #301
Conversation
Unless you're planning on running tests in the browser (which node-pre-gyp probably isn't going to do), node-tap might be a better fit. Then you get the runner, reporter, coverage, and test framework all in one. |
Any status update? |
…not contain exact version
f2eb911
to
b189695
Compare
Going to stick with tape for the moment. I'm short on time and it was not immediately obvious to me how to port node-pre-gyp/test/build.test.js Lines 37 to 44 in 07704da
|
Refactor tests / port to tape
While debugging #300 I suspected that the mocha tests might be behaving unpredictably. I wondered if porting to tape would resolve the issues in #300. They did not, but moving to
tape
seems ideal anyway (given https://macwright.org/2014/03/11/tape-is-cool.html). so I forged ahead on these.Also solved in this PR along the way:
After the nodejs series started releasing 2.x and above we've seen the ABI only get bumped with new major versions, predictably.
we now assume the ABI even when the exact minor.patch version is not stored in the abi crosswalk. This will avoid it needing to be updated as frequently (only for new major versions).