Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests / port to tape #301

Merged
merged 18 commits into from
Sep 7, 2017
Merged

Refactor tests / port to tape #301

merged 18 commits into from
Sep 7, 2017

Conversation

springmeyer
Copy link
Contributor

@springmeyer springmeyer commented Jun 11, 2017

While debugging #300 I suspected that the mocha tests might be behaving unpredictably. I wondered if porting to tape would resolve the issues in #300. They did not, but moving to tape seems ideal anyway (given https://macwright.org/2014/03/11/tape-is-cool.html). so I forged ahead on these.

Also solved in this PR along the way:

@isaacs
Copy link
Contributor

isaacs commented Jun 11, 2017

Unless you're planning on running tests in the browser (which node-pre-gyp probably isn't going to do), node-tap might be a better fit. Then you get the runner, reporter, coverage, and test framework all in one.

@ajmas
Copy link

ajmas commented Aug 25, 2017

Any status update?

@springmeyer
Copy link
Contributor Author

Going to stick with tape for the moment. I'm short on time and it was not immediately obvious to me how to port

test.Test.prototype.stringContains = function(actual, contents, message) {
this._assert(actual.indexOf(contents) > -1, {
message: message || 'should contain '+contents,
operator: 'stringContains',
actual: actual,
expected: contents
});
};
over.

@springmeyer springmeyer merged commit 9be0bde into master Sep 7, 2017
@springmeyer springmeyer deleted the tape-tests branch September 7, 2017 20:02
hyj1991 pushed a commit to X-Profiler/node-pre-gyp that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants