Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

Using carto to generate data.xml #4

Closed
yhahn opened this issue Mar 27, 2013 · 2 comments
Closed

Using carto to generate data.xml #4

yhahn opened this issue Mar 27, 2013 · 2 comments

Comments

@yhahn
Copy link
Member

yhahn commented Mar 27, 2013

Per chat convo with @tmcw, mapbox/carto@5d626d3 breaks tm2's usage of carto for generating style-less mapnik XML for datasources.

Carto's behavior of skipping layers that have no styles defined for them is totally sensible for the rest of the world, so will have to do some meditation on how to proceed here (flag in carto? would it make sense to anyone else? should tm2 just template its own datasource XML (not that much code)?)

Going to pin to a hash for now.

yhahn pushed a commit that referenced this issue Mar 27, 2013
@springmeyer
Copy link
Contributor

once mapbox/carto#247 is fixed there will be strong incentive in my mind to start pulling in an updated tag of carto, so this issue should track that.

@springmeyer
Copy link
Contributor

the original issue that was solved and broke tm2 usage (mapbox/carto#244) is now a non-critical and could be rolled back. The reason for this is that latest Mapnik also can avoid the overhead of empty styles after mapnik/mapnik@0d8f415 | mapnik/mapnik#1670

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants