-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaceTilesetSource method #404
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great thanks, looks like just needs a rebase against main to rebuild the docs.
Hey there! Any chance this could get merged and a new version deployed? I could really use this in a current project. If any help is needed to get this merged I would be happy to help out. Thanks! |
This would be a valuable addition for me. Can we get this in? |
9283b82
to
80bef3b
Compare
80bef3b
to
2d05657
Compare
rebased against main with rebuilt docs |
I think best to leave it as
Definitely a separate method sounds best to me, as it mirrors the main API and the method name is immediately clear on what it does. |
Can we please get this merged in. |
This adds the
Tilesets.replaceTilesetSource
method to the Tilesets service. https://docs.mapbox.com/api/maps/#replace-a-tileset-sourceI'm reading through the development requirements, and think I need to verify a few things:
put*
, so should I rename this toTilesets.putTilesetSource
? Happy to change it!replace: true
option toTilesets.createTilesetSource
method instead of an entirely new method. This would effectively change POST to PUT, but I wasn't able to find any instances of this pattern in the rest of the SDK. Thoughts on this idea?Also massive h/t to @andrewharvey for adding the Tilesets service to the SDK originally. So good!
cc @katydecorah @andrewharvey
closes #432