-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Places plugin #171
Places plugin #171
Conversation
Love it @cammace . I'm going to call it |
Damn your quick @langsmith :) not sure what naming we want to go with here either. |
gradle/dependencies.gradle
Outdated
robolectric : '3.4.2', | ||
lifecycleCompiler : '1.0.0', | ||
lifecycleRuntime : '1.0.3' | ||
mapboxMapSdk : '5.2.0-beta.4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid conflicts with Lost, we should bump mapboxMapSdk
version to 5.2.0
.
Per mapbox/mapbox-gl-native#9488 the location provider is optional (we're not including Lost within the SDK anymore) and in mapbox/mapbox-gl-native#10355 we bumped the Lost version to
3.0.4
https://github.com/mapbox/mapbox-gl-native/blob/ffea8e145f5b67bbeb7aec46c77d73b95ef6ea31/platform/android/dependencies.gradle#L23 which is the one that MAS2.2.9
uses.
9a528d2
to
c2058f5
Compare
This guy's ready for a first pass review. Although I plan to merge into master, the test will be coming after in a different PR since this one is already reaching a large number of lines. |
* Adds README to places plugin folder * adding places plugin line to repo readme * tweaks * fixed a few typos * nit line
…plugins-android into cam-plugin-places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, quick glance through didn't show anything worth addressing. Maybe good to have a second pair of 👀 on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @tobrun here - looks great. Let's get it merged and start testing
As part of the Mapbox Java 3.0 release, we are removing the geocoder widget and replacing it with a new, feature rich, version. The places plugin will eventually (not all in this PR) include a location picker activity, place details bottom sheet view, and an autocomplete activity (this PR).
First, you have two autocomplete modes, one with the cards, and the other full screen. You'll pick this in this intent builder among other options as seen below:
when the activity starts it looks like this:
The cards which include bright blue text are the CarmenFeatures which were injected using the IntentBuilder, Useful for including users home/work address or quick access to other favorite places.
When the user selects an item from the list, the activity finishes, and the picked CarmenFeature is received through
onActivityResult
.cc: @mapbox/android