Fix traffic congestion rendering issues. #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds which allow to create route lines if needed. Fixed defect which was calling incorrect delegate method for alternateRoutesCasingLayer.
…ring route line gradient calculation.
… already added route layer.
MaximAlien
added
bug
MaximAlien
commented
Aug 31, 2020
|
|
||
| @discardableResult func addAlternateRoutesLayer(_ style: MGLStyle, source: MGLSource, below layer: MGLStyleLayer) -> MGLStyleLayer { | ||
| let customAlternateRoutesLayer = navigationMapViewDelegate?.navigationMapView(self, | ||
| alternativeRouteStyleLayerWithIdentifier: StyleLayerIdentifier.alternateRoutes, |
There was a problem hiding this comment.
At this point we use NavigationMapViewDelegate.navigationMapView(_:alternativeRouteStyleLayerWithIdentifier:source:) and NavigationMapViewDelegate.navigationMapView(_:alternateRouteCasingStyleLayerWithIdentifier:source:). @1ec5, maybe it'd be better to use the same convention here? As I can see alternate is mostly used in NavigationMapView, maybe we should use the same naming in public API method?
Suggested change
| alternativeRouteStyleLayerWithIdentifier: StyleLayerIdentifier.alternateRoutes, | |
| alternateRouteStyleLayerWithIdentifier: StyleLayerIdentifier.alternateRoutes, |
There was a problem hiding this comment.
It should be “alternative” consistently. “Alternate” is easily read as a verb in this context, and it has a slightly different meaning anyways.
1ec5
approved these changes
Sep 2, 2020
| let mainRouteCasingShape = navigationMapViewDelegate?.navigationMapView(self, shapeFor: [mainRoute]) ?? shape(for: [mainRoute], legIndex: legIndex) | ||
| let mainRouteCasingSource = addMainRouteCasingSource(style, shape: mainRouteCasingShape) | ||
|
|
||
| let mainRouteLayer = addMainRouteLayer(style, source: allRoutesSource, lineGradient: routeLineGradient(mainRoute, fractionTraveled: 0.0)) |
There was a problem hiding this comment.
The new helper methods make this method much easier to follow, thanks!
MaximAlien
added a commit
that referenced
this pull request
Sep 3, 2020
Fix traffic congestion rendering issues. (cherry picked from commit 4aaf88c)
MaximAlien
added a commit
that referenced
this pull request
Sep 3, 2020
* Update to MapboxDirections v0.33.2. (#2585) (cherry picked from commit 6e54f9d) * Merge pull request #2586 from mapbox/maxim/2584-update-navigation-styles Update day/night style URLs. (cherry picked from commit 24c83ea) * Merge pull request #2580 from mapbox/maxim/2574-fix-traffic-congestion Fix traffic congestion rendering issues. (cherry picked from commit 4aaf88c) * Merge pull request #2581 from mapbox/maxim/2526-make-fade-route-public Make updateRoute(_:) public. (cherry picked from commit bfed4ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #2574.
I've slightly re-worked original implementation. Now there are such methods which allow to add route layers:
Such methods are used to create line gradient:
In case if route layer was already added route line gradient with congestion segments will be retrieved out of it.
For route casing color is always the same (without congestions), but fading is also added depending on route progress.
Current PR also fixes #2423 and #2512.