Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust API Milestone to handle new routes #425

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Adjust API Milestone to handle new routes #425

merged 3 commits into from
Oct 27, 2017

Conversation

danesfeder
Copy link
Contributor

@danesfeder danesfeder commented Oct 26, 2017 •
edited by cammace
Loading

Closes #419

  • still needs to properly detect new routes given previousRouteProgress and the current route progress

cc @ericrwolfe

@danesfeder danesfeder added the bug Defect to be fixed. label Oct 26, 2017
@danesfeder danesfeder added this to the v0.7.0 milestone Oct 26, 2017
@danesfeder danesfeder self-assigned this Oct 26, 2017
@danesfeder danesfeder added the ⚠️ DO NOT MERGE PR should not be merged! label Oct 26, 2017
@danesfeder danesfeder added ✓ ready for review and removed ⚠️ DO NOT MERGE PR should not be merged! labels Oct 26, 2017
danesfeder
danesfeder commented Oct 26, 2017
View reviewed changes
...main/java/com/mapbox/services/android/navigation/v5/milestone/VoiceInstructionMilestone.java
*/
private boolean shouldBeVoiced(RouteProgress routeProgress, VoiceInstructions voice) {
return voice.distanceAlongGeometry()
>= routeProgress.currentLegProgress().currentStepProgress().distanceRemaining();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsudekum @1ec5 Do you have any other logic for the voice announcements other than if the instruction distance along the geometry is >= to the current step distance remaining?

@danesfeder danesfeder merged commit c8b3877 into master Oct 27, 2017
@danesfeder danesfeder deleted the dan-reroute-apimilestone branch October 27, 2017 00:29
Grsmto pushed a commit to Grsmto/mapbox-navigation-android that referenced this pull request Oct 27, 2017
Merge branch 'master' of https://github.com/mapbox/mapbox-navigation-…
9338368 
…android into fix-build

* 'master' of https://github.com/mapbox/mapbox-navigation-android:
  Adjust API Milestone to handle new routes (mapbox#425)
  Cancel notification when the service is destroyed, not just when notification button is clicked (mapbox#409)
  adds validation utils class (mapbox#424)
  Wait for map style to load before initializing run time styling (mapbox#423)
  Changed up NavigationRoute (mapbox#413)

# Conflicts:
#	libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationRoute.java
@danesfeder danesfeder mentioned this pull request Nov 13, 2017
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @cammace