Add check to avoid ArrayIndexOutOfBoundsExceptions from MapRouteLine#drawWayPoints

[Guardiola31337]

Description

Fixes #1948
Regression from #1387

• I have added any issue links
• I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
• I have added the appropriate milestone and project boards

Goal

Adds a check to avoid ArrayIndexOutOfBoundsExceptions from MapRouteLine#drawWayPoints

Implementation

Adds a check into MapRouteLine#updatePrimaryRouteIndex to cover the scenario for when newPrimaryIndex is not valid - could be -1 if not found 👀

mapbox-navigation-android/libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/route/MapRouteClickListener.java

Line 65 in 92ab4eb

int newPrimaryRouteIndex = directionsRoutes.indexOf(clickedRoute);

Testing

Please describe the manual tests that you ran to verify your changes

• I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
• I have tested via a test drive, or a simulation/mock location app
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have updated the CHANGELOG including this PR

[devotaaabel]

Should this be >=0 ?

[Guardiola31337]

Yeah, you're right! Great catch!

[codecov-io]

Codecov Report

Merging #1951 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1951      +/-   ##
============================================
+ Coverage     36.93%   36.96%   +0.02%     
- Complexity     1130     1133       +3     
============================================
  Files           273      273              
  Lines          9080     9080              
  Branches        677      677              
============================================
+ Hits           3354     3356       +2     
+ Misses         5427     5426       -1     
+ Partials        299      298       -1