Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fix for origin and destination overriding list #420

Merged
merged 3 commits into from
Mar 30, 2017
Merged

Conversation

cammace
Copy link
Contributor

@cammace cammace commented Mar 30, 2017

closes: #378

replaces PR #383

you are allowed to set only origin and destination or origin, destination, and a list of coordinates. if a list is provided, it will go in between the origin and destination when creating the string for the API.

@zugaldia
Copy link
Member

A couple of tests are failing:

com.mapbox.services.api.directions.v5.MapboxDirectionsTest > testSetCoordinatesMixedHidden FAILED
    org.junit.ComparisonFailure at MapboxDirectionsTest.java:559

com.mapbox.services.api.directions.v5.MapboxDirectionsTest > testLocale FAILED
    org.junit.ComparisonFailure at MapboxDirectionsTest.java:575

@cammace cammace merged commit 0285600 into master Mar 30, 2017
@cammace cammace deleted the cam-378-fix branch March 30, 2017 18:11
@cammace cammace mentioned this pull request Apr 15, 2017
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resetting origin or destination in same directions builder, adds to list instead of replacing
2 participants