Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Isochrone API #1596

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

cafesilencio
Copy link
Contributor

@cafesilencio cafesilencio commented Sep 26, 2024

Added updates to Isochrone API to support new features like driving-traffic profile, contours_meters, road/route exclusions and departure date/time.

@cafesilencio cafesilencio force-pushed the sb-3734-update-isocrone-services branch 7 times, most recently from 1650d25 to 6eb36b2 Compare September 26, 2024 20:50
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (b33ae25) to head (93a3561).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...java/com/mapbox/api/isochrone/MapboxIsochrone.java 82.22% 1 Missing and 7 partials ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1596      +/-   ##
============================================
+ Coverage     77.93%   78.03%   +0.09%     
  Complexity     1066     1066              
============================================
  Files           158      158              
  Lines          4450     4493      +43     
  Branches        617      630      +13     
============================================
+ Hits           3468     3506      +38     
  Misses          714      714              
- Partials        268      273       +5     
Flag Coverage Δ
78.03% <82.22%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/com/mapbox/api/isochrone/IsochroneCriteria.java 0.00% <ø> (ø)
...java/com/mapbox/api/isochrone/MapboxIsochrone.java 86.31% <82.22%> (+1.70%) ⬆️

@cafesilencio cafesilencio marked this pull request as ready for review September 26, 2024 21:15
@cafesilencio cafesilencio requested a review from a team as a code owner September 26, 2024 21:15
CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines 253 to 254
public Builder addContoursMeters(@NonNull @IntRange(from = 0, to = 100000)
Integer... listOfMeterValues) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public Builder addContoursMeters(@NonNull @IntRange(from = 0, to = 100000)
Integer... listOfMeterValues) {
public Builder addContoursMeters(@NonNull Integer... listOfMeterValues) {

Let's not add the integer range, this range can be dynamically changed on the backend.

Comment on lines 245 to 246
* must be in increasing order. The maximum distance that can be specified
* is 100000 meters (100km).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* must be in increasing order. The maximum distance that can be specified
* is 100000 meters (100km).
* must be in increasing order. The default maximum distance that can be specified
* is 100000 meters (100km), if you need a bigger range contact support.

Comment on lines 278 to 279
* increasing order. The maximum distance that can be specified
* is 100000 meters (100km).
Copy link
Contributor

@LukasPaczos LukasPaczos Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* increasing order. The maximum distance that can be specified
* is 100000 meters (100km).
* increasing order. The default maximum distance that can be specified
* is 100000 meters (100km), if you need a bigger range contact support.

@cafesilencio cafesilencio merged commit 22599ef into main Sep 30, 2024
4 of 5 checks passed
@cafesilencio cafesilencio deleted the sb-3734-update-isocrone-services branch September 30, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants