-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Isochrone API #1596
Updates to Isochrone API #1596
Conversation
1650d25
to
6eb36b2
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1596 +/- ##
============================================
+ Coverage 77.93% 78.03% +0.09%
Complexity 1066 1066
============================================
Files 158 158
Lines 4450 4493 +43
Branches 617 630 +13
============================================
+ Hits 3468 3506 +38
Misses 714 714
- Partials 268 273 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
public Builder addContoursMeters(@NonNull @IntRange(from = 0, to = 100000) | ||
Integer... listOfMeterValues) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public Builder addContoursMeters(@NonNull @IntRange(from = 0, to = 100000) | |
Integer... listOfMeterValues) { | |
public Builder addContoursMeters(@NonNull Integer... listOfMeterValues) { |
Let's not add the integer range, this range can be dynamically changed on the backend.
* must be in increasing order. The maximum distance that can be specified | ||
* is 100000 meters (100km). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* must be in increasing order. The maximum distance that can be specified | |
* is 100000 meters (100km). | |
* must be in increasing order. The default maximum distance that can be specified | |
* is 100000 meters (100km), if you need a bigger range contact support. |
* increasing order. The maximum distance that can be specified | ||
* is 100000 meters (100km). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* increasing order. The maximum distance that can be specified | |
* is 100000 meters (100km). | |
* increasing order. The default maximum distance that can be specified | |
* is 100000 meters (100km), if you need a bigger range contact support. |
6eb36b2
to
6e918f2
Compare
6e918f2
to
93a3561
Compare
Added updates to Isochrone API to support new features like driving-traffic profile, contours_meters, road/route exclusions and departure date/time.