This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivovandongen
approved these changes
Jul 19, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleans up nicely!
} | ||
|
||
void RenderAnnotationSource::finishRender(Painter& painter) { | ||
void RenderAnnotationSource::finishRender(PaintParameters& painter) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit; rename parameter
jfirebaugh
force-pushed
the
painter-renderer
branch
from
July 19, 2017 15:31
ac2598f
to
6ad349f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor capitalizes on the asynchronous rendering work, particularly #9327, to simplify the set of rendering-related classes. In particular, it moves all of the code in
Painter
to better places:Painter::render<LayerType>
becomesRender<LayerType>Layer::render
. As a special case, there was some fill-extrusion-related code that wasn't inPainter::renderFillExtrusion
-- that moved toRenderFillExtrusionLayer::render
too.Painter::renderTileDebug
had two overloads. The one for rendering tile debugging becomesRenderTile::finishRender
. The one for rendering image source debug borders becomesRenderImageSource::finishRender
.Painter::render{ClippingMask,Item,Pass,ClipMasks,DepthBuffer}
were inlined intoPainter::render
.Finally, what was left of
Painter
itself was parceled out:RenderStaticData
render
methods need moved toPaintParameters
(which we should next rename toRenderParameters
)Painter::render
method, which was merged intoRenderer::Impl