This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid creating InfoWindow iterator if no InfoWindows are shown #9477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
reviewed
Jul 13, 2017
| @@ -56,10 +58,6 @@ boolean isAllowConcurrentMultipleOpenInfoWindows() { | |||
| return allowConcurrentMultipleInfoWindows; | |||
| } | |||
|
|
|||
| List<InfoWindow> getInfoWindows() { | |||
There was a problem hiding this comment.
Why do we need to remove this getter?
There was a problem hiding this comment.
it was unused & not part of our public api
tobrun
force-pushed
the
tvn-avoid-iterating
branch
from
c2bd866
to
41f7bf1
Compare
Guardiola31337
approved these changes
Jul 17, 2017
| @@ -31,12 +32,13 @@ | |||
| private MapboxMap.OnInfoWindowCloseListener onInfoWindowCloseListener; | |||
|
|
|||
| InfoWindowManager() { | |||
There was a problem hiding this comment.
No need to keep this empty constructor.
tobrun
force-pushed
the
tvn-avoid-iterating
branch
2 times, most recently
from
790b7ae
to
d92f726
Compare
tobrun
force-pushed
the
tvn-avoid-iterating
branch
from
d92f726
to
dabb168
Compare
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we receive a region change event, we are synchronizing Android SDK view components on top of the map. With profiling of gestures in #9476, I'm noticing we are allocating iterators for InfoWindows while no InfoWindows are shown. Checking for an empty avoids creating unneeded allocations.