This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Use AAssetManager instead of bundling libzip #8712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android NDK exposes
AAssetManager
, which is a way to access theAssetManager
, which is a way to access resources from the zipfile (among other things).Implementing this would allow us to get rid of bundling libzip, and at the same time change the meaning of "asset" to be the Android definition of "asset".