-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[android] - Transifex intregration and Dutch translations. #8556
Conversation
@tobrun I believe this is worth including in the CHANGELOG. |
d266796
to
6cf5a96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A run of tx pull -a
shows that this PR works as advertised. I did notice that tx
changed several existing .strings files back to UTF-16 encoding (which git treats as binary), so we’ll have to keep an eye out for that and restore UTF-8 encoding to those files.
Incidentally, you may want to run tx pull -a
to get the Catalan translation, which has been updated in Transifex to cover the new Android strings! 🎉
If you haven’t already, don’t forget to configure Transifex to fetch the raw version of strings.xml daily.
I saw this as well, wasn't sure if this was expected behavior. Thank you for adding this.
Wow, that was fast! or should I say:
I haven't, will look into it. |
6cf5a96
to
a4d1b34
Compare
@tobrun 😂
^ |
add Catalan translations
a4d1b34
to
5719e26
Compare
This PR adds mapbox-gl-native Transifex project integration for the Android Mapbox SDK.
To test integration, Dutch translations were added.
@1ec5 I moved the lang_map of the previous integration to the specific tasks (Android follows
the ISO 639-1 standard). I feel this was the best solution as applying a lang_map to a specific task will not override the project lang_map but will extend it.
cc @mapbox/android