This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Upright CJK characters in vertically-oriented labels #7114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@1ec5, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jfirebaugh, @ChrisLoer and @kkaefer to be potential reviewers. |
|
@1ec5 what needs to happen until this can be merged? |
|
CJK characters and adjacent punctuation now remain upright in vertically oriented labels that have line placement. Fixes #1682.
jfirebaugh
force-pushed
the
1ec5-縱排-7114
branch
from
ec88534
to
6111c7e
Compare
jfirebaugh
removed
the
⚠️ DO NOT MERGE
|
@1ec5 I rebased this and debugged the test failures -- can you take a look? |
1ec5
commented
Feb 10, 2017
There was a problem hiding this comment.
Thanks @jfirebaugh! Now it all makes sense. 😊 These changes also look a lot cleaner now that the WritingDirection enumeration has been removed on master.
|
|
||
| // https://github.com/mapbox/mapbox-gl/issues/29 | ||
|
|
||
| // if (isInMeroiticHieroglyphs(chr)) return true; |
There was a problem hiding this comment.
mapbox/mapbox-gl-js#3608 (comment) requested that I put the list of vertical supplementary blocks in mapbox/DEPRECATED-mapbox-gl#29, now mapbox/mapbox-gl-js#4001, instead of leaving them here as commented out lines.
jfirebaugh
approved these changes
Feb 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CJK characters and adjacent punctuation now remain upright in vertically oriented labels that have line placement.
This is a port of mapbox/mapbox-gl-js#3438 that fixes #1682. I did most of the porting before #6984 landed, so I have yet to reconcile the
WritingModeenumeration with the newWritingDirectionenumeration. Also, vertical punctuation is correctly laid out but doesn’t appear for some reason. I suspect the issue has to do with the glyph range not being loaded, but I need to do further investigation./cc @kkaefer @lucaswoj @ChrisLoer @LornTao