This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Use swift_name for MGLMultiPoint and subclasses #6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decorate the class factory methods so that when they are translated to swift the method to create an MGLMultiPoint is not ambiguous with the methods to create MGLPolygon and MGLPolyline.
boundsj
added
iOS
|
We discovered that this change would break some existing Swift applications. So we’re going to fix #5201 for the v3.4.0 release, eliminating the need for the |
friedbunny
added a commit
to mapbox/ios-sdk-examples
that referenced
this pull request
Oct 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6524 we added a class factory method to
MGLMultiPoint. SinceMGLMultiPointis a superclass ofMGLPolylineandMGLPolygon, when modern Swift 3 translation rules are applied, the result is ambiguous class factory method names for MultiPoint -> PolyLine and Polygon.This change decorates the class factory methods with
NS_SWIFT_NAME({shape_name}(coordinates:count:))so that, at the call site in a modern Swift app, we can write:cc @friedbunny @1ec5