Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Update Android SDK, gradle plugin and mapzen lib #6548

Closed
wants to merge 2 commits into from
Closed

[android] Update Android SDK, gradle plugin and mapzen lib #6548

wants to merge 2 commits into from

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Oct 1, 2016 •
edited
Loading

Update Android SDK version to 24 (Android 7)
Update mapzen lost library to 2.0.0 with required code changes
Update gradle Android plugin to 2.2

@clydebarrow
[android] Update Android SDK version to 24 (Android 7)
ef1492f 
          Update mapzen lost library to 2.0.0 with required code changes
          Update gradle Android plugin to 2.2
          Remove android-sdk-manager plugin (functionality now incorporated in Android plugin)
@mention-bot
Copy link

@clydebarrow, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bleege, @tobrun and @ljbade to be potential reviewers.

This was referenced Oct 1, 2016
Closed
Closed
@clydebarrow
Reverted the removal plugin android-sdk-manager.
c4875e9 
While the android gradle plugin 2.2.0 is supposed to have incorporated the
functionality of this plugin, it's not clear that it's fully working,
and this plugin appears to do no harm.
@tobrun tobrun added the Android Mapbox Maps SDK for Android label Oct 3, 2016
@zugaldia zugaldia added ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Oct 3, 2016
@zugaldia zugaldia added this to the android-future milestone Oct 3, 2016
@zugaldia
Copy link
Member

zugaldia commented Oct 3, 2016

@clydebarrow Thank you very much for this PR, this is something that we're definitely interested in bringing to the SDK.

I'd note though that this PR, as you mention in the OP, changes the targetSdkVersion to Nougat, as well as increments the support libraries versions. This means that SEMVER is affected and we won't be able to merge this into the SDK as part of the 4.x series. Let's track this PR as part of the larger work to improve our support of Android 7 in #6197. Sounds good?

@clydebarrow
Copy link
Contributor Author

The LOST upgrade doesn't depend on the targetSdkVersion change, so I could split it out into a separate PR if you like.

@zugaldia
Copy link
Member

zugaldia commented Oct 3, 2016

@clydebarrow Thank you for the offer but we'll still need to wait. LOST 2.0 itself brings some changes that will require further changes from us. See, for example, #6462 (comment) and #4331.

@clydebarrow clydebarrow closed this Oct 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Milestone
android-v5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@clydebarrow @mention-bot @zugaldia @tobrun