This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Make Xcode 7.3 the minimum required version #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @1ec5 and @incanus to be potential reviewers. |
friedbunny
changed the title
|
This PR doesn’t handle macOS yet. |
| @@ -6,6 +6,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
|
|
|||
| * A new runtime styling API allows you to adjust the style and content of the base map dynamically. All the options available in [Mapbox Studio](https://www.mapbox.com/studio/) are now exposed via MGLStyle and subclasses of MGLStyleLayer and MGLSource. ([#5727](https://github.com/mapbox/mapbox-gl-native/pull/5727)) | |||
| * The user location annotation is now customizable via the newly added `MGLUserLocationAnnotationView` class. ([#5882](https://github.com/mapbox/mapbox-gl-native/pull/5882)) | |||
| * Xcode 7.3 or higher is now officially required to build and integrate this SDK. ([#6059](https://github.com/mapbox/mapbox-gl-native/issues/6059)) | |||
There was a problem hiding this comment.
Nit: remove “officially”. Also, “install” or “link against” would be more relevant to most readers than “build and integrate”.
There was a problem hiding this comment.
How about “use this SDK”?
|
This was already done for iOS; now it’s also done for macOS. |
|
👍 |
friedbunny
force-pushed
the
fb-xcode-7.3
branch
2 times, most recently
from
f7e53d4
to
25dfa83
Compare
friedbunny
changed the title
- Removes nullability shims for Xcode 6. - Removes MGLTypes.h from files where it was only being used for nullability support. - Accepts that `NS_SWIFT_NAME` is not fully supported by Xcode 7.2 and lower. - Adds documentation about Xcode 7.3 requirement.
friedbunny
force-pushed
the
fb-xcode-7.3
branch
from
25dfa83
to
256689a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes Xcode 7.3 the minimum version requirement to build and integrate the iOS SDK.
This removes
#import “MGLTypes.h”from headers where it was only being used to conditionally defineNS_ASSUME_NONNULL_*and various nullability traits, which were necessary to support Xcode 6.Xcode 7.3 becomes the minimum supported version because of
NS_SWIFT_NAME, which is not fully supported by lower versions (and we were already using it).@frederoni I also removed the MGLTypes.h import from the runtime styling generation template and regenerated.
Fixes #5472.
/cc @1ec5 @tmcw