This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
5869 android query rendered features #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivovandongen
added
feature
Android
ivovandongen
force-pushed
the
5869-android-query-rendered-features
branch
from
acd2521
to
aa3ff20
Compare
| */ | ||
| @UiThread | ||
| @NonNull | ||
| public List<Feature> queryRenderedFeatures(@NonNull PointF coordinates, @Nullable String... layerIds) { |
There was a problem hiding this comment.
varargs is great for this use-case!
|
Added some nit remarks, but LGTM 🚢 |
ivovandongen
force-pushed
the
5869-android-query-rendered-features
branch
2 times, most recently
from
a279ea2
to
b215dca
Compare
ivovandongen
force-pushed
the
5869-android-query-rendered-features
branch
from
b215dca
to
4e21154
Compare
ivovandongen
removed
the
⚠️ DO NOT MERGE
|
cc @mapbox/android |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for testing