[core] Restore AnnotationSource maximum zoom range to 22

[brunoabinader]

This is a work-in-progress PR.

So far:

• Implemented a unit test that reproduces the missing annotation on z19: Annotations.AnnotationZoomRange
• Fixed tolerance level when generating the GeoJSONVT shape tiler in ShapeAnnotationImpl::updateTileData - this change makes the subsequent query for shapeTile.features return a non-empty TileFeature.
• However, TileFeature still contains an empty tile ring in its geometry. This is what makes queryRenderedFeatures return no features in the test case, and causes the annotations to disappear in zoom 19.

For the last item, I'm suspecting either 1) an erroneous parameter passed out to GeoJSONVT via Options struct or 2) an unknown bug inside geojson-vt-cpp.

Fixes #5505.

👀 @mourner @kkaefer @jfirebaugh

[brunoabinader]

I've compiled geojson-vt-cpp 4.1.2 (current version @ GL Native) in debug mode and got the following output:

tile z18-131071-131072 (features: 1, points: 2, simplified: 2)
creation: 0.01ms
drilling down: 0.05ms
shapeFeature.tileGeometry.shapeRing.size: 2
drilling down to z18-131071-131071
found parent tile z17-65535-65535
clipping: 0.01ms
tile z18-131071-131071 (features: 1, points: 2, simplified: 2)
creation: 0.01ms
drilling down: 0.05ms
shapeFeature.tileGeometry.shapeRing.size: 2
drilling down to z18-131072-131072
found parent tile z17-65536-65536
clipping: 0.01ms
tile z18-131072-131072 (features: 1, points: 2, simplified: 2)
creation: 0.01ms
drilling down: 0.04ms
shapeFeature.tileGeometry.shapeRing.size: 2
drilling down to z18-131072-131071
found parent tile z17-65536-65535
clipping: 0.02ms
tile z18-131073-131070 (features: 1, points: 2, simplified: 2)
creation: 0.01ms
tile z18-131072-131071 (features: 1, points: 2, simplified: 2)
creation: 0.01ms
tile z18-131072-131070 (features: 1, points: 2, simplified: 2)
creation: 0.00ms
drilling down: 0.07ms
shapeFeature.tileGeometry.shapeRing.size: 2
drilling down to z19-262144-262143
found parent tile z18-131072-131071
clipping: 0.03ms
tile z19-262145-262142 (features: 1, points: 2, simplified: 0)
creation: 0.01ms
tile z19-262144-262143 (features: 1, points: 2, simplified: 0)
creation: 0.01ms
tile z19-262144-262142 (features: 1, points: 2, simplified: 0)
creation: 0.01ms
drilling down: 0.11ms
shapeFeature.tileGeometry.shapeRing.size: 0
drilling down to z19-262144-262144
found parent tile z18-131072-131072
clipping: 0.01ms
tile z19-262144-262144 (features: 1, points: 2, simplified: 0)
creation: 0.01ms
drilling down: 0.04ms
shapeFeature.tileGeometry.shapeRing.size: 0
drilling down to z19-262143-262143
found parent tile z18-131071-131071
clipping: 0.01ms
tile z19-262143-262143 (features: 1, points: 2, simplified: 0)
creation: 0.01ms
drilling down: 0.04ms
shapeFeature.tileGeometry.shapeRing.size: 0
drilling down to z19-262143-262144
found parent tile z18-131071-131072
clipping: 0.01ms
tile z19-262143-262144 (features: 1, points: 2, simplified: 0)
creation: 0.01ms
drilling down: 0.03ms
shapeFeature.tileGeometry.shapeRing.size: 0

As it seems, tile generation for z19 returns empty simplified features. Interesting to check with latest geojson-vt-cpp to see if the same behavior happens (/cc @yhahn).

[mourner]

Capturing from chat:

@brunoabinader: given the unit test I added yesterday to geojson-vt-cpp doesn't capture the issue I see in #5517 (comment) - I'm ought to believe that this has been fixed between versions 4.1.2 and 6.0.0

[jfirebaugh]

The algorithm works fine without checking these boundary conditions right? Why increase the amount of code?

[brunoabinader]

This is an early return - avoids unnecessary creation of queryGeometry.