This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Don't validate/delete shaders #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it ensured that Shader Destructor is called on map Thread? |
|
@mb12 yeah; the shader objects are owned by the Painter object, which is owned by the MapContext object, which gets destructed on the Map thread. |
kkaefer
force-pushed
the
2147-dont-validate-delete-shaders
branch
from
dde8507
to
d3c7173
Compare
|
Interesting, is not not possible to tweak when we do validate program? |
kkaefer
force-pushed
the
2147-dont-validate-delete-shaders
branch
from
d3c7173
to
65087d5
Compare
it's not in a state where validation always succeeds with all drivers, e.g. because textures might not be attached yet
some GPU drivers have issues with deleting shader objects that are attached to programs. while this is allowed by the spec, it seems that some drivers are crashing nonetheless.
kkaefer
force-pushed
the
2147-dont-validate-delete-shaders
branch
from
65087d5
to
5ef7011
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GPU drivers, such as the Tegra 3 (used in the Nexus 7) seem to have issues with our call to
glValidateProgram. They are technically right about not validating since the time when we validate our shaders, we don't have the correct OpenGL state (e.g. textures) set yet.Similarly, we're calling
glDeleteShaderin the shader object constructor, after the shader has been attached to the program. While this is technically correct according to the spec, this particular driver seems to crash when doing deleting the shader object. Instead, we can just hold off on deleting the shader object until the shader destructor.