This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Handle zero text size #16080
Merged
[core] Handle zero text size #16080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style specification stipulates that `text-size` values must be positive (https://docs.mapbox.com/mapbox-gl-js/style-spec/#layout-symbol-text-size). However, a zero value could be passed to the engine (e.g. as a result of an expression) this patch handles it and avoids assertion hit in `shaping.cpp`.
tmpsantos
approved these changes
Dec 19, 2019
Merged
jmkiley
added a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 19, 2019
jmkiley
added a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style specification stipulates that
text-sizevalues must be positive(https://docs.mapbox.com/mapbox-gl-js/style-spec/#layout-symbol-text-size).
However, a zero value could be passed to the engine (e.g. as a result of
an expression). This PR handles it and thus avoids an assertion hit in
shaping.cpp.The render test : mapbox/mapbox-gl-js#9133
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/129