This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Correct padding management in cameraForLatLngBounds #16067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repurpose LatLngBoundsToCameraWithBearingAndPitch to test scaling and camera setup, both with and without padding. This adds testing of path not covered in mapbox/mapbox-gl-native-ios#59.
pozdnyakov
approved these changes
Dec 17, 2019
astojilj
added a commit
to mapbox/mapbox-navigation-ios
that referenced
this pull request
Jul 18, 2020
As a result of fix mapbox/mapbox-gl-native#16067, contentInsets are taken into account when calculating camera. in iOS code, current view's contentInset is passed to calculate camera. Simplify the approach here by passing .zero, as edgePadding in MGLMapView in cameraThatFitsShape and camera has additive character: gets appended to view's contentInset.
This was referenced Jul 18, 2020
ChristianSteffens
added a commit
to ChristianSteffens/mapbox-navigation-ios
that referenced
this pull request
Jul 24, 2020
As a result of fix mapbox/mapbox-gl-native#16067, contentInsets are taken into account when calculating camera. in iOS code, current view's contentInset is passed to calculate camera. Simplify the approach here by passing .zero, as edgePadding in MGLMapView in cameraThatFitsShape and camera has additive character: gets appended to view's contentInset.
ChristianSteffens
added a commit
to ChristianSteffens/mapbox-navigation-ios
that referenced
this pull request
Jul 25, 2020
As a result of fix mapbox/mapbox-gl-native#16067, contentInsets are taken into account when calculating camera. in iOS code, current view's contentInset is passed to calculate camera. Simplify the approach here by passing .zero, as edgePadding in MGLMapView in cameraThatFitsShape and camera has additive character: gets appended to view's contentInset. # Conflicts: # MapboxNavigation/RouteMapViewController.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit external contribution: #16061.
Include padding when testing camera scale in cameraForLatLngBounds:
Repurpose LatLngBoundsToCameraWithBearingAndPitch to test scaling and camera setup, both with and without padding.
Padding test (LatLngBoundsToCameraWithExcessivePadding) is not testing scaling code path in cameraForLatLngBounds. This adds the test for it and makes the test less permissive. See mapbox/mapbox-gl-native-ios#59.