-
Notifications
You must be signed in to change notification settings - Fork 1.3k
MapView reuse, integration test suite #14127
Conversation
@ivovandongen Below a gif showing the crash: The crash occurs when you scroll the MapView back into view. When that happens a The symbolized stack trace here. |
…k, don't destroy map renderer when surface is destroyed as it can be recreated later
9c08843
to
f556b90
Compare
f556b90
to
eb1fd28
Compare
@tobrun Like we discussed on chat. I think ideally we would introduce finer grained callbacks, distinguishing from (EGL) context and surface creation/destroys. Cleanup of the renderer / backend can then happen on the context related signals and no longer on surface signals so that re-use of the context with a different surface can be supported seamlessly. In the TextureViewRenderer we have plenty of control and it should be relatively easy to do. For the GLSurfaceViewRenderer, I think we can set a custom Let's make that a new issue though and continue on this path now. |
BTW: great addition of the integration tests! Makes everything so much easier to reproduce. |
14f96bc
to
f109f38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all those tests! A couple of minor comments/questions below.
...oidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/integration/OrientationChangeTest.kt
Show resolved
Hide resolved
platform/android/MapboxGLAndroidSDKTestApp/src/main/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
...SDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/fragment/ViewPagerActivity.kt
Show resolved
Hide resolved
...ain/java/com/mapbox/mapboxsdk/testapp/activity/maplayout/ChildFragmentMapInDialogActivity.kt
Outdated
Show resolved
Hide resolved
3b19a79
to
9f71a1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9f71a1d
to
8790154
Compare
Follow up from #13926 and #13976. Since 7.2.0, our map freezes when used in a View reuse scenario. Since this went unnoticed, I'm am adding a new integration test suite using UiAutomator.
MapView freezes in RecyclerView - 4d98991
OnSurfaceCreated
in a similar fashion toOnSurfaceDestroyed
.Integration test suite - 676d7dd
This PR introduces an integration test-suite that will harden against regressions. I added a handful of others occurrences that had regressed in the past.
cc @mapbox/maps-android